You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Aryeh Sivan (JIRA)" <ji...@apache.org> on 2009/10/05 17:36:53 UTC

[jira] Created: (AMQ-2441) TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4

TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4
----------------------------------------------------

                 Key: AMQ-2441
                 URL: https://issues.apache.org/activemq/browse/AMQ-2441
             Project: ActiveMQ
          Issue Type: Bug
          Components: Broker
    Affects Versions: 5.3.0
            Reporter: Aryeh Sivan
            Priority: Minor


Due to the adding of the new properties to TimeStampingBrokerPlugin the "message.setTimestamp()" was misplaced and is set to early in the code.

The line need to be placed as the last line in the method send() as was in 5.2.

In addition the Plugin doesn't handle the scenario where the Broker is running "behind" its client. What is happening is that it's setting the Expiration and TimeStamp to historical values in the client perspective causing them to be discarded by the clients.

I have supplied a patch that solves both issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-2441) TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4

Posted by "Aryeh Sivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aryeh Sivan updated AMQ-2441:
-----------------------------

    Attachment: TimeStampingBrokerPlugin.java

Fix

> TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4
> ----------------------------------------------------
>
>                 Key: AMQ-2441
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2441
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.3.0
>            Reporter: Aryeh Sivan
>            Priority: Minor
>         Attachments: TimeStampingBrokerPlugin.java
>
>
> Due to the adding of the new properties to TimeStampingBrokerPlugin the "message.setTimestamp()" was misplaced and is set to early in the code.
> The line need to be placed as the last line in the method send() as was in 5.2.
> In addition the Plugin doesn't handle the scenario where the Broker is running "behind" its client. What is happening is that it's setting the Expiration and TimeStamp to historical values in the client perspective causing them to be discarded by the clients.
> I have supplied a patch that solves both issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-2441) TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4

Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dejan Bosanac resolved AMQ-2441.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3.0
         Assignee: Dejan Bosanac

I applied modified patch. I set that ignoring setting values in the past is optional and off by default. It makes sense in some use cases, for example when all clients are on the same machine. But what if only some producers have wrong clocks and consumers are in the sync with the broker? The purpose of this plugin is to use broker time as relevant, but with this patch it will be also possible to prevent these changes. All you have to do is to set futureOnly property to true. Thanks

> TimeStampingBrokerPlugin Not Working on Fuse 5.3.0.4
> ----------------------------------------------------
>
>                 Key: AMQ-2441
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2441
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.3.0
>            Reporter: Aryeh Sivan
>            Assignee: Dejan Bosanac
>            Priority: Minor
>             Fix For: 5.3.0
>
>         Attachments: TimeStampingBrokerPlugin.java
>
>
> Due to the adding of the new properties to TimeStampingBrokerPlugin the "message.setTimestamp()" was misplaced and is set to early in the code.
> The line need to be placed as the last line in the method send() as was in 5.2.
> In addition the Plugin doesn't handle the scenario where the Broker is running "behind" its client. What is happening is that it's setting the Expiration and TimeStamp to historical values in the client perspective causing them to be discarded by the clients.
> I have supplied a patch that solves both issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.