You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jacksontj <gi...@git.apache.org> on 2016/10/13 18:53:55 UTC
[GitHub] trafficserver pull request #1105: TS-4968: Log a warning if connect_attempts...
GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/1105
TS-4968: Log a warning if connect_attempts_rr_retries is >= connect_attempts_max_retries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacksontj/trafficserver TS-4968
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1105
----
commit 4ca4ca26e22864f415595f5be3a364e9f881ec99
Author: Thomas Jackson <ja...@gmail.com>
Date: 2016-10-13T18:53:20Z
TS-4968: Log a warning if connect_attempts_rr_retries is >= connect_attempts_max_retries
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1105: TS-4968: Log a warning if connect_attempts_rr_ret...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1105
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/895/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1105: TS-4968: Log a warning if connect_attempts...
Posted by jacksontj <gi...@git.apache.org>.
Github user jacksontj closed the pull request at:
https://github.com/apache/trafficserver/pull/1105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1105: TS-4968: Log a warning if connect_attempts...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1105#discussion_r83445904
--- Diff: proxy/http/HttpConfig.cc ---
@@ -1224,12 +1224,16 @@ HttpConfig::reconfigure()
params->oride.connect_attempts_max_retries = m_master.oride.connect_attempts_max_retries;
params->oride.connect_attempts_max_retries_dead_server = m_master.oride.connect_attempts_max_retries_dead_server;
- params->oride.connect_attempts_rr_retries = m_master.oride.connect_attempts_rr_retries;
- params->oride.connect_attempts_timeout = m_master.oride.connect_attempts_timeout;
- params->oride.post_connect_attempts_timeout = m_master.oride.post_connect_attempts_timeout;
- params->oride.parent_connect_attempts = m_master.oride.parent_connect_attempts;
- params->per_parent_connect_attempts = m_master.per_parent_connect_attempts;
- params->parent_connect_timeout = m_master.parent_connect_timeout;
+ if (m_master.oride.connect_attempts_rr_retries >= params->oride.connect_attempts_max_retries) {
+ Warning("connect_attempts_rr_retries is greater than connect_attempts_max_retries, this means requests will never redispatch "
--- End diff --
Print the actual values here. AFAIK Traffic Server docs don't use the term ``real``, maybe just say ``will never be retried``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1105: TS-4968: Log a warning if connect_attempts...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1105#discussion_r83463301
--- Diff: proxy/http/HttpConfig.cc ---
@@ -1224,12 +1224,16 @@ HttpConfig::reconfigure()
params->oride.connect_attempts_max_retries = m_master.oride.connect_attempts_max_retries;
params->oride.connect_attempts_max_retries_dead_server = m_master.oride.connect_attempts_max_retries_dead_server;
- params->oride.connect_attempts_rr_retries = m_master.oride.connect_attempts_rr_retries;
- params->oride.connect_attempts_timeout = m_master.oride.connect_attempts_timeout;
- params->oride.post_connect_attempts_timeout = m_master.oride.post_connect_attempts_timeout;
- params->oride.parent_connect_attempts = m_master.oride.parent_connect_attempts;
- params->per_parent_connect_attempts = m_master.per_parent_connect_attempts;
- params->parent_connect_timeout = m_master.parent_connect_timeout;
+ if (m_master.oride.connect_attempts_rr_retries >= params->oride.connect_attempts_max_retries) {
+ Warning("connect_attempts_rr_retries is greater than connect_attempts_max_retries, this means requests will never redispatch "
--- End diff --
I don't know that you need to be that specific, I just wasn't sure that operators would be familiar with the ``reals`` terminology.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1105: TS-4968: Log a warning if connect_attempts_rr_ret...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1105
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/999/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1105: TS-4968: Log a warning if connect_attempts_rr_ret...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1105
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1003/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1105: TS-4968: Log a warning if connect_attempts_rr_ret...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1105
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1106/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---