[jira] [Commented] (SOLR-11665) Unexpected behaviour when splitShardCmd can not create replicas due to policy framework

["Andrzej Bialecki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264251#comment-16264251 ] 

Andrzej Bialecki  commented on SOLR-11665:
------------------------------------------

I noticed a couple other issues in SplitShardCmd:
{code}
// Remove the node that hosts the parent shard for replica creation.
      nodeList.remove(nodeName);

      // TODO: change this to handle sharding a slice into > 2 sub-shards.

      List<ReplicaPosition> replicaPositions = Assign.identifyNodes(ocmh.cloudManager,
          clusterState,
          new ArrayList<>(clusterState.getLiveNodes()),
          collectionName,
          new ZkNodeProps(collection.getProperties()),
          subSlices, repFactor - 1, 0, 0);
{code}
* In this section, the call to {{Assign.identifyNodes}} should use the {{nodeList}} prepared above, and not all live nodes.
* this call also uses {{repFactor - 1}} for NRT replicas, ignoring other types of replicas specified in the collection config.
* further down, this section also assumes all replicas are NRT:
{code}
      for (int i = 0; i < subRanges.size(); i++) {
        String subSlice = slice + "_" + i;
        subSlices.add(subSlice);
        String subShardName = Assign.buildSolrCoreName(ocmh.cloudManager.getDistribStateManager(), collection, subSlice, Replica.Type.NRT);
        subShardNames.add(subShardName);
      }
{code}
This results in incorrect names being created for SolrCore-s.

> Unexpected behaviour when splitShardCmd can not create replicas due to policy framework
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-11665
>                 URL: https://issues.apache.org/jira/browse/SOLR-11665
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>         Attachments: SOLR-11665.test.patch
>
>
> I do see some problems when doing split shard but there are no available nodes for creating replicas ( due to policy framework )
> - The patch contains a test, in which sub shard stay in CONSTRUCTION state forever.
> - Shard which get split, stay in inactive state forever and subshards are not created



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org