[jira] [Commented] (STORM-188) Allow user to specifiy full configuration path when running storm command

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004233#comment-14004233 ] 

ASF GitHub Bot commented on STORM-188:
--------------------------------------

GitHub user clockfly opened a pull request:

    https://github.com/apache/incubator-storm/pull/120

    STORM-188: Allow user to specifiy full configuration path when running storm command

    We can use system config "storm.conf.file" to specify a custom config file.
    
    Before this patch, we will only try to lookup this file on jvm classpath.
    
    This patch will give us the ability to specify full/relative filesystem path as configuration file path, thus will give us more flexibility, while we still are able to look it up on jvm classpath.
    
    Now we are able to submit storm topology like this: 
    
    ```bash
    storm jar job.jar --config /tmp/dynamic-configuration-path.yaml
    ```
    
    We don't need to add /tmp into our classpath(also inappropriate).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clockfly/incubator-storm storm-188-storm-config-support-localfs-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-storm/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #120
    
----
commit 0512fb461504d31f3011417e9ac66bc7b4a8f8e1
Author: Sean Zhong <cl...@gmail.com>
Date:   2014-05-21T02:03:33Z

    STORM-188: when looking up storm.yaml, should also try to search file system path if we cannot find it on classpath

----


> Allow user to specifiy full configuration path when running storm command
> -------------------------------------------------------------------------
>
>                 Key: STORM-188
>                 URL: https://issues.apache.org/jira/browse/STORM-188
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Sean Zhong
>            Priority: Minor
>         Attachments: search_local_path_for_config.patch, storm-188.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Currently, storm will only look up configuration path in java classpath. We should also allow user to specify full configuration path. This is very important for a shared cluster environment, like YARN. Multiple storm cluster may runs with different configuration, but share same binary folder.



--
This message was sent by Atlassian JIRA
(v6.2#6252)