You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Hiteshgautam01 <gi...@git.apache.org> on 2018/03/09 19:40:40 UTC
[GitHub] incubator-taverna-mobile pull request #69: Improvements in Login Screen UI
GitHub user Hiteshgautam01 opened a pull request:
https://github.com/apache/incubator-taverna-mobile/pull/69
Improvements in Login Screen UI
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [ ] Run the checks with `./gradlew check` to make sure you didn't break anything
- [ ] If you have multiple commits please combine them into one commit by squashing them.
UI after Changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hiteshgautam01/incubator-taverna-mobile Impovements_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-mobile/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit 5585bd2c7dd8f8261907cc1e43ce32a9491d8f9a
Author: Hitesh Gautam <ga...@...>
Date: 2018-03-09T19:33:54Z
Improvements in Login Screen UI
----
---
[GitHub] incubator-taverna-mobile pull request #69: Improvements in Login Screen UI
Posted by sagar15795 <gi...@git.apache.org>.
Github user sagar15795 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/69#discussion_r173614685
--- Diff: app/src/main/res/drawable/login_button.xml ---
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<shape xmlns:android="http://schemas.android.com/apk/res/android"
+ android:shape="rectangle" android:padding="10dp">
+ <!-- you can use any color you want I used here gray color-->
--- End diff --
remove this unwanted comment
---
[GitHub] incubator-taverna-mobile pull request #69: Improvements in Login Screen UI
Posted by saketkumar95 <gi...@git.apache.org>.
Github user saketkumar95 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/69#discussion_r173614607
--- Diff: app/src/main/res/layout/fragment_login.xml ---
@@ -32,8 +32,8 @@
<ImageView
android:id="@+id/logo"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
+ android:layout_width="70dp"
+ android:layout_height="70dp"
--- End diff --
Adds these all in `dimens.xml` file
---
[GitHub] incubator-taverna-mobile pull request #69: Improvements in Login Screen UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-taverna-mobile/pull/69
---
[GitHub] incubator-taverna-mobile pull request #69: Improvements in Login Screen UI
Posted by sagar15795 <gi...@git.apache.org>.
Github user sagar15795 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/69#discussion_r173614694
--- Diff: app/src/main/res/drawable/login_button.xml ---
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<shape xmlns:android="http://schemas.android.com/apk/res/android"
+ android:shape="rectangle" android:padding="10dp">
+ <!-- you can use any color you want I used here gray color-->
+ <solid android:color="@color/colorPrimaryDark"/>
+ <corners android:radius="80dp"/>
--- End diff --
Move this to `dimens.xml`
---