You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/01/23 21:01:25 UTC
[kudu-CR] tool: remove dead code
Hello Dinesh Bhat, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5770
to review the following change.
Change subject: tool: remove dead code
......................................................................
tool: remove dead code
Change-Id: I93b173c4f2f91d1d7466f99ddc3264a8796e5b51
---
D src/kudu/tools/fs_dump-tool.cc
D src/kudu/tools/fs_list-tool.cc
2 files changed, 0 insertions(+), 366 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/5770/1
--
To view, visit http://gerrit.cloudera.org:8080/5770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93b173c4f2f91d1d7466f99ddc3264a8796e5b51
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: remove dead code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: tool: remove dead code
......................................................................
tool: remove dead code
Change-Id: I93b173c4f2f91d1d7466f99ddc3264a8796e5b51
Reviewed-on: http://gerrit.cloudera.org:8080/5770
Tested-by: Kudu Jenkins
Reviewed-by: Dinesh Bhat <di...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
D src/kudu/tools/fs_dump-tool.cc
D src/kudu/tools/fs_list-tool.cc
2 files changed, 0 insertions(+), 366 deletions(-)
Approvals:
Dinesh Bhat: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93b173c4f2f91d1d7466f99ddc3264a8796e5b51
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: remove dead code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: tool: remove dead code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b173c4f2f91d1d7466f99ddc3264a8796e5b51
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: remove dead code
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: tool: remove dead code
......................................................................
Patch Set 1: Code-Review+1
It's good you noticed them Adar. Ship it from my side.
--
To view, visit http://gerrit.cloudera.org:8080/5770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b173c4f2f91d1d7466f99ddc3264a8796e5b51
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No