You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by davies <gi...@git.apache.org> on 2015/02/18 01:42:13 UTC
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/4666
[SPARK-5722] [SQL] [PySpark] infer int as LongType
The `int` is 64-bit on 64-bit machine (very common now), we should infer it as LongType for it in Spark SQL.
Also, LongType in SQL will come back as `int`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davies/spark long
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4666
----
commit 6bc6cc49a88877e923b96a932953cb395b0be368
Author: Davies Liu <da...@databricks.com>
Date: 2015-02-18T00:38:29Z
infer int as LongType
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74799115
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27664/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74788669
[Test build #27664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27664/consoleFull) for PR 4666 at commit [`6bc6cc4`](https://github.com/apache/spark/commit/6bc6cc49a88877e923b96a932953cb395b0be368).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74800097
[Test build #613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/613/consoleFull) for PR 4666 at commit [`6bc6cc4`](https://github.com/apache/spark/commit/6bc6cc49a88877e923b96a932953cb395b0be368).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74960589
Thanks! Merged to master and 1.3. @dondrake this doesn't apply cleanly to branch-1.2. @davies, how hard would this be to back port?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74788241
[Test build #613 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/613/consoleFull) for PR 4666 at commit [`6bc6cc4`](https://github.com/apache/spark/commit/6bc6cc49a88877e923b96a932953cb395b0be368).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by dondrake <gi...@git.apache.org>.
Github user dondrake commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74799310
@davies THANKS!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74799108
[Test build #27664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27664/consoleFull) for PR 4666 at commit [`6bc6cc4`](https://github.com/apache/spark/commit/6bc6cc49a88877e923b96a932953cb395b0be368).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74965855
@marmbrus I will create another patch for 1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5722] [SQL] [PySpark] infer int as Long...
Posted by dondrake <gi...@git.apache.org>.
Github user dondrake commented on the pull request:
https://github.com/apache/spark/pull/4666#issuecomment-74963829
Great news on 1.3.
Please see #4521 for my PR for branch-1.2. It's not exactly the same as what @davies did for 1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org