You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "LoganZhuZzz (via GitHub)" <gi...@apache.org> on 2024/08/22 06:10:52 UTC
[PR] KAFKA-17388: Remove broker-list in VerifiableProducer [kafka]
LoganZhuZzz opened a new pull request, #16958:
URL: https://github.com/apache/kafka/pull/16958
The broker-list option is no longer supported in version 4.0.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17388: Remove broker-list in VerifiableProducer [kafka]
Posted by "LoganZhuZzz (via GitHub)" <gi...@apache.org>.
LoganZhuZzz commented on code in PR #16958:
URL: https://github.com/apache/kafka/pull/16958#discussion_r1730719630
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java:
##########
@@ -131,14 +131,6 @@ private static ArgumentParser argParser() {
.dest("bootstrapServer")
.help("REQUIRED: The server(s) to connect to. Comma-separated list of Kafka brokers in the form HOST1:PORT1,HOST2:PORT2,...");
- connectionGroup.addArgument("--broker-list")
Review Comment:
Thank you for the feedback! I appreciate the clarification regarding the --bootstrap-server flag. I'll update the code to ensure that --bootstrap-server is only used when the Kafka version is 2.5 or higher. For lower versions, I'll retain the use of --broker-list as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17388: Remove broker-list in VerifiableProducer [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16958:
URL: https://github.com/apache/kafka/pull/16958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17388: Remove broker-list in VerifiableProducer [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16958:
URL: https://github.com/apache/kafka/pull/16958#discussion_r1730325275
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java:
##########
@@ -131,14 +131,6 @@ private static ArgumentParser argParser() {
.dest("bootstrapServer")
.help("REQUIRED: The server(s) to connect to. Comma-separated list of Kafka brokers in the form HOST1:PORT1,HOST2:PORT2,...");
- connectionGroup.addArgument("--broker-list")
Review Comment:
@LoganZhuZzz could you please update e2e also? see https://github.com/apache/kafka/blob/11966a209a8bb5bbf867b5bb5ca1d60b80e26650/tests/kafkatest/services/verifiable_producer.py#L227
noted that we should use `--bootstrap-server` only if the version >= 2.5. otherwise, we should keep using `--broker-list`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17388: Remove broker-list in VerifiableProducer [kafka]
Posted by "LoganZhuZzz (via GitHub)" <gi...@apache.org>.
LoganZhuZzz commented on PR #16958:
URL: https://github.com/apache/kafka/pull/16958#issuecomment-2304653222
> LGTM
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org