You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Jason Pell (JIRA)" <ji...@apache.org> on 2013/01/24 02:46:11 UTC
[jira] [Commented] (CXF-4776) UsernameTokenPolicyValidator does not
validate that password is not provided.
[ https://issues.apache.org/jira/browse/CXF-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561335#comment-13561335 ]
Jason Pell commented on CXF-4776:
---------------------------------
My suggested patch is an inverse of the NoPassword check validation.
Index: src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/UsernameTokenPolicyValidator.java
===================================================================
--- src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/UsernameTokenPolicyValidator.java (revision 1437320)
+++ src/main/java/org/apache/cxf/ws/security/wss4j/policyvalidators/UsernameTokenPolicyValidator.java (working copy)
@@ -98,6 +98,10 @@
ai.setNotAsserted("Username Token NoPassword policy not enforced");
return false;
}
+ if (!usernameTokenPolicy.isNoPassword() && usernameToken.getPassword() == null) {
+ ai.setNotAsserted("Password policy not enforced");
+ return false;
+ }
if (usernameTokenPolicy.isRequireCreated()
&& (usernameToken.getCreated() == null || usernameToken.isHashed())) {
ai.setNotAsserted("Username Token Created policy not enforced");
> UsernameTokenPolicyValidator does not validate that password is not provided.
> -----------------------------------------------------------------------------
>
> Key: CXF-4776
> URL: https://issues.apache.org/jira/browse/CXF-4776
> Project: CXF
> Issue Type: Bug
> Components: WS-* Components
> Affects Versions: 2.7.2
> Reporter: Jason Pell
> Assignee: Jason Pell
> Attachments: UsernamePasswordPolicy.xml
>
>
> See my attached WS-Policy which I attached via @Policies annotation to Placement.BINDING_OPERATION_INPUT.
> If I include an incorrect Password I get the expected authentication error. If I actually remove the password I get no authentication failure. The UsernameTokenPolicyValidator only checks that the username is provided.
> I have a simple patch for this but would appreciate some weigh in from ws-policy cxf devs please.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira