[GitHub] [spark] cloud-fan commented on a change in pull request #35404: [SPARK-38118][SQL] MEAN(Boolean) in the HAVING claus should throw data mismatch error

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35404:
URL: https://github.com/apache/spark/pull/35404#discussion_r800325130



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
##########
@@ -46,6 +46,8 @@ case class Average(
 
   def this(child: Expression) = this(child, failOnError = SQLConf.get.ansiEnabled)
 
+  override lazy val resolved: Boolean = children.forall(_.resolved)

Review comment:
       It's intentional that `Expression.resolved` also checks the input data types. It seems weird to me that we only change it for `Average`...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org