You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2020/08/19 07:15:00 UTC

[jira] [Commented] (YUNIKORN-374) Use compatible GRPC version in core

    [ https://issues.apache.org/jira/browse/YUNIKORN-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180319#comment-17180319 ] 

Wilfred Spiegelenburg commented on YUNIKORN-374:
------------------------------------------------

After thinking a bit more about this: I do not understand is why are we running into this issue now?
YUNIKORN-47 was fixed in March, we have build and released a version of YuniKorn. So why would updating the K8s to a *newer* version force us to downgrade grpc.

Looking at the etcd version mentioned in the build info is also not what I see in the {{go.mod}} file for the current trunk:
{code}
github.com/coreos/etcd v3.3.20+incompatible // indirect
{code}
So we are downgrading etcd to an earlier release somehow?

This does not make sense to me at all...

> Use compatible GRPC version in core
> -----------------------------------
>
>                 Key: YUNIKORN-374
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-374
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - common
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>
> Current grpc version used in scheduler-interface seems too high, which is not compatible with coreos etcd v3.3.17:
> {code}
> go build -o=_output/bin/k8s_yunikorn_scheduler -race -ldflags \
>         '-X main.version=latest -X main.date=2020-08-13T15:59:39-0700' \
>     ./pkg/shim/
> # github.com/coreos/etcd/clientv3/balancer/picker
> ../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.17+incompatible/clientv3/balancer/picker/err.go:37:44: undefined: balancer.PickOptions
> ../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.17+incompatible/clientv3/balancer/picker/roundrobin_balanced.go:55:54: undefined: balancer.PickOptions
> # github.com/coreos/etcd/clientv3/balancer/resolver/endpoint
> ../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.17+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:114:78: undefined: resolver.BuildOption
> ../../../../go/pkg/mod/github.com/coreos/etcd@v3.3.17+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:182:31: undefined: resolver.ResolveNowOption
> # k8s.io/component-base/metrics/legacyregistry
> {code}
> K8s 1.16 is using: 
> {code}
> k8s.io/apiextensions-apiserver@v0.0.0 google.golang.org/grpc@v1.23.0
> k8s.io/apiserver@v0.16.13 google.golang.org/grpc@v1.23.0
> k8s.io/apiserver@v0.16.13 github.com/tmc/grpc-websocket-proxy@v0.0.0-20170815181823-89b8d40f7ca8
> k8s.io/apiserver@v0.16.13 github.com/grpc-ecosystem/grpc-gateway@v1.3.0
> k8s.io/apiserver@v0.16.13 github.com/grpc-ecosystem/go-grpc-prometheus@v1.2.0
> k8s.io/apiserver@v0.16.13 github.com/grpc-ecosystem/go-grpc-middleware@v0.0.0-20190222133341-cfaf5686ec79
> k8s.io/cri-api@v0.0.0 google.golang.org/grpc@v1.23.0
> k8s.io/apiserver@v0.0.0 github.com/grpc-ecosystem/go-grpc-middleware@v0.0.0-20190222133341-cfaf5686ec79
> k8s.io/apiserver@v0.0.0 github.com/grpc-ecosystem/go-grpc-prometheus@v1.2.0
> k8s.io/apiserver@v0.0.0 github.com/grpc-ecosystem/grpc-gateway@v1.3.0
> k8s.io/apiserver@v0.0.0 github.com/tmc/grpc-websocket-proxy@v0.0.0-20170815181823-89b8d40f7ca8
> k8s.io/apiserver@v0.0.0 google.golang.org/grpc@v1.23.0
> k8s.io/kubernetes@v1.16.13 google.golang.org/grpc@v1.23.0
> {code}
> I think we should use v1.23.0 as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org