[GitHub] [trafficserver] serrislew commented on a diff in pull request #9181: Adding back set_connect_fail for generic I/O error

[GitBox <gi...@apache.org>]

serrislew commented on code in PR #9181:
URL: https://github.com/apache/trafficserver/pull/9181#discussion_r1020596576


##########
tests/gold_tests/dns/replay/server_down.replay.yaml:
##########
@@ -0,0 +1,54 @@
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+meta:
+  version: "1.0"
+
+sessions:
+- transactions:
+  - client-request:
+      delay: 2s

Review Comment:
   The client request delay is to allow the host file to sync so HostDB will include entries and the DelayStart is specific to the test run. I don't think the test run actually needs a delay so I will remove that one and also add comments to the replay file!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org