[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #1109: nimble/phy/nrf: Move rx_end to disabled event

[GitBox <gi...@apache.org>]

andrzej-kaczmarek opened a new pull request #1109:
URL: https://github.com/apache/mynewt-nimble/pull/1109


   This moves handling of PDU RX end from EVENT_END to EVENT_DISABLED.
   This will allow to run our phy on BabbleSim and also seems to simplify
   code a bit.
   
   EVENT_DISABLED happens almost immediately after EVENT_END, so on real
   it happens while ble_phy_isr is being executed and is simply ignored.
   However, on BabbleSim code is executed as if time was paused which
   means that no other event can occur when ble_phy_isr is being executed,
   i.e. it will be called after we return from isr and simulation code can
   trigger subsequent events. If rx_end configures transition to TX and
   thus enables interrupt on EVENT_DISABLED, we will handle that during an
   event that is triggered for RX - basically we handle tx_end before TX
   even started. Using EVENT_DISABLED for both TX and RX resolves this
   issue.
   
   We still use timer capture on EVENT_END for transition timing so this
   has no effect on that calculations, and since EVENT_DISABLED occurs
   just a fraction of microsecond after EVENT_END, execution timings are
   also not affected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1109: nimble/phy/nrf: Move rx_end to disabled event

[GitBox <gi...@apache.org>]

andrzej-kaczmarek merged pull request #1109:
URL: https://github.com/apache/mynewt-nimble/pull/1109


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org