You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/04/27 10:20:45 UTC
[GitHub] [ignite] tledkov-gridgain opened a new pull request #7745: IGNITE-12886 Introduce separate SQL configuration
tledkov-gridgain opened a new pull request #7745:
URL: https://github.com/apache/ignite/pull/7745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #7745: IGNITE-12886 Introduce separate SQL configuration
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on a change in pull request #7745:
URL: https://github.com/apache/ignite/pull/7745#discussion_r425035421
##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java
##########
@@ -313,12 +320,6 @@
/** Index create/rebuild pool size. */
private int buildIdxPoolSize = DFLT_BUILD_IDX_THREAD_POOL_SIZE;
Review comment:
Not agreed. All we configure and start all executor services at the IgnitionEx.IgniteNamedInstance#start0. So it looks looks like a core feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #7745: IGNITE-12886 Introduce separate SQL configuration
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on a change in pull request #7745:
URL: https://github.com/apache/ignite/pull/7745#discussion_r425072024
##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/SqlConfiguration.java
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.configuration;
+
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.S;
+
+/**
+ * The configuration of the SQL query subsystem.
+ */
+public class SqlConfiguration {
+ /** Default SQL query history size. */
+ public static final int DFLT_SQL_QUERY_HISTORY_SIZE = 1000;
+
+ /** Default query timeout. */
+ public static final long DFLT_QRY_TIMEOUT = 0;
+
+ /** Default timeout after which long query warning will be printed. */
+ public static final long DFLT_LONG_QRY_WARN_TIMEOUT = 3000;
+
+ /** */
+ private long longQryWarnTimeout = DFLT_LONG_QRY_WARN_TIMEOUT;
+
+ /** Default query timeout. */
+ private long dfltQryTimeout = DFLT_QRY_TIMEOUT;
+
+ /** SQL schemas to be created on node start. */
+ private String[] sqlSchemas;
+
+ /** SQL query history size. */
+ private int sqlQryHistSize = DFLT_SQL_QUERY_HISTORY_SIZE;
+
+ /**
+ * Defines the default query timeout.
+ *
+ * Defaults to {@link #DFLT_QRY_TIMEOUT}.
+ * {@code 0} means there is no timeout (this
+ * is a default value)
Review comment:
Fixed
##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/SqlConfiguration.java
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.configuration;
+
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.S;
+
+/**
+ * The configuration of the SQL query subsystem.
+ */
+public class SqlConfiguration {
+ /** Default SQL query history size. */
+ public static final int DFLT_SQL_QUERY_HISTORY_SIZE = 1000;
+
+ /** Default query timeout. */
+ public static final long DFLT_QRY_TIMEOUT = 0;
+
+ /** Default timeout after which long query warning will be printed. */
+ public static final long DFLT_LONG_QRY_WARN_TIMEOUT = 3000;
+
+ /** */
+ private long longQryWarnTimeout = DFLT_LONG_QRY_WARN_TIMEOUT;
+
+ /** Default query timeout. */
+ private long dfltQryTimeout = DFLT_QRY_TIMEOUT;
+
+ /** SQL schemas to be created on node start. */
+ private String[] sqlSchemas;
+
+ /** SQL query history size. */
+ private int sqlQryHistSize = DFLT_SQL_QUERY_HISTORY_SIZE;
+
+ /**
+ * Defines the default query timeout.
+ *
+ * Defaults to {@link #DFLT_QRY_TIMEOUT}.
+ * {@code 0} means there is no timeout (this
+ * is a default value)
+ *
+ * @return Default query timeout.
+ */
+ public long getDefaultQueryTimeout() {
+ return dfltQryTimeout;
+ }
+
+ /**
+ * Sets timeout in milliseconds for default query timeout.
+ * {@code 0} means there is no timeout (this
+ * is a default value)
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #7745: IGNITE-12886 Introduce separate SQL configuration
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7745:
URL: https://github.com/apache/ignite/pull/7745#discussion_r424999436
##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/SqlConfiguration.java
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.configuration;
+
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.S;
+
+/**
+ * The configuration of the SQL query subsystem.
+ */
+public class SqlConfiguration {
+ /** Default SQL query history size. */
+ public static final int DFLT_SQL_QUERY_HISTORY_SIZE = 1000;
+
+ /** Default query timeout. */
+ public static final long DFLT_QRY_TIMEOUT = 0;
+
+ /** Default timeout after which long query warning will be printed. */
+ public static final long DFLT_LONG_QRY_WARN_TIMEOUT = 3000;
+
+ /** */
+ private long longQryWarnTimeout = DFLT_LONG_QRY_WARN_TIMEOUT;
+
+ /** Default query timeout. */
+ private long dfltQryTimeout = DFLT_QRY_TIMEOUT;
+
+ /** SQL schemas to be created on node start. */
+ private String[] sqlSchemas;
+
+ /** SQL query history size. */
+ private int sqlQryHistSize = DFLT_SQL_QUERY_HISTORY_SIZE;
+
+ /**
+ * Defines the default query timeout.
+ *
+ * Defaults to {@link #DFLT_QRY_TIMEOUT}.
+ * {@code 0} means there is no timeout (this
+ * is a default value)
Review comment:
Let's remove linefeed here to make more readable.
##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java
##########
@@ -313,12 +320,6 @@
/** Index create/rebuild pool size. */
private int buildIdxPoolSize = DFLT_BUILD_IDX_THREAD_POOL_SIZE;
Review comment:
Should this be a part of SqlConfiguration as well?
##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/SqlConfiguration.java
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.configuration;
+
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.S;
+
+/**
+ * The configuration of the SQL query subsystem.
+ */
+public class SqlConfiguration {
+ /** Default SQL query history size. */
+ public static final int DFLT_SQL_QUERY_HISTORY_SIZE = 1000;
+
+ /** Default query timeout. */
+ public static final long DFLT_QRY_TIMEOUT = 0;
+
+ /** Default timeout after which long query warning will be printed. */
+ public static final long DFLT_LONG_QRY_WARN_TIMEOUT = 3000;
+
+ /** */
+ private long longQryWarnTimeout = DFLT_LONG_QRY_WARN_TIMEOUT;
+
+ /** Default query timeout. */
+ private long dfltQryTimeout = DFLT_QRY_TIMEOUT;
+
+ /** SQL schemas to be created on node start. */
+ private String[] sqlSchemas;
+
+ /** SQL query history size. */
+ private int sqlQryHistSize = DFLT_SQL_QUERY_HISTORY_SIZE;
+
+ /**
+ * Defines the default query timeout.
+ *
+ * Defaults to {@link #DFLT_QRY_TIMEOUT}.
+ * {@code 0} means there is no timeout (this
+ * is a default value)
+ *
+ * @return Default query timeout.
+ */
+ public long getDefaultQueryTimeout() {
+ return dfltQryTimeout;
+ }
+
+ /**
+ * Sets timeout in milliseconds for default query timeout.
+ * {@code 0} means there is no timeout (this
+ * is a default value)
Review comment:
Let's remove linefeed here to make more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain closed pull request #7745: IGNITE-12886 Introduce separate SQL configuration
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain closed pull request #7745:
URL: https://github.com/apache/ignite/pull/7745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org