[GitHub] [maven] gnodet commented on a diff in pull request #1124: [MNG-7097] Plugin Dependency Resolution

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #1124:
URL: https://github.com/apache/maven/pull/1124#discussion_r1203959215


##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java:
##########
@@ -300,4 +311,40 @@ public boolean visitLeave(DependencyNode node) {
             return true;
         }
     }
+
+    private static class CoreDependencySelector implements DependencySelector {
+        private final HashSet<String> coreArtifacts;
+
+        private CoreDependencySelector(final Collection<String> coreArtifacts) {
+            this.coreArtifacts = new HashSet<>(coreArtifacts);
+        }
+
+        @Override
+        public boolean selectDependency(final org.eclipse.aether.graph.Dependency dependency) {

Review Comment:
   I'm not a big fan of the `final` keyword on arguments and local variable... They are actually only useful on fields.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org