You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/23 06:16:11 UTC

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #2193: [KYUUBI #1915] invoke tpcds from sql

ulysses-you commented on a change in pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#discussion_r832012546



##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/zorder/ZorderSqlExtensions.g4
##########
@@ -76,6 +82,11 @@ comparisonOperator
     : EQ | NEQ | NEQJ | LT | LTE | GT | GTE | NSEQ
     ;
 
+expression

Review comment:
       I'm a little confused with this name. I see it comes from iceberg, but why not name it as `argument` ? The semantics of expression in Spark is different with this pr.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org