You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2018/12/02 04:21:00 UTC

[jira] [Resolved] (ARROW-3870) [C++] Add Peek to InputStream API

     [ https://issues.apache.org/jira/browse/ARROW-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney resolved ARROW-3870.
---------------------------------
    Resolution: Fixed

Issue resolved by pull request 3064
[https://github.com/apache/arrow/pull/3064]

> [C++] Add Peek to InputStream API
> ---------------------------------
>
>                 Key: ARROW-3870
>                 URL: https://issues.apache.org/jira/browse/ARROW-3870
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.12.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Some InputStream sources support lookahead without advancing the stream, like BufferReader and BufferedInputStream. This is used in Parquet's internal IO APIs, so it would be useful to be able to remove these after a deprecation cycle
> https://github.com/apache/arrow/blob/master/cpp/src/parquet/util/memory.h#L375
> If an InputStream does not support Peek, the returned {{string_view}} would have zero size. 
> Another option is to have {{Peek}} return {{Status}}, so that NotImplemented can be returned. I would prefer to return 0-length if the operation is not supported



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)