[GitHub] [arrow-datafusion] WinkerDu commented on a change in pull request #2108: fix df union all bug

[GitBox <gi...@apache.org>]

WinkerDu commented on a change in pull request #2108:
URL: https://github.com/apache/arrow-datafusion/pull/2108#discussion_r837357519



##########
File path: datafusion-common/src/dfschema.rs
##########
@@ -281,6 +281,14 @@ impl DFSchema {
             .all(|(dffield, arrowfield)| dffield.name() == arrowfield.name())
     }
 
+    /// Check to see if df field data types in df schema matches with input df schema
+    pub fn matches_arrow_schema_with_type(&self, df_schema: &DFSchema) -> bool {
+        self.fields
+            .iter()

Review comment:
       @Ted-Jiang Agree with that.
   Maybe we can solve `Alias` issue first, than open a new issue to fully discuss data type compatible cast?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org