You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2024/07/20 15:09:47 UTC

[kudu-CR] just a test

Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21604


Change subject: just a test
......................................................................

just a test

Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/21604/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................

KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Reduce the failure rate of the test by lowering its loop
times. For example, when FLAGS_block_manager == "logr",
opens a data directory will open a RocksDB instance, it
consumes more time than that if FLAGS_block_manager == "log".

Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Reviewed-on: http://gerrit.cloudera.org:8080/21604
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

Thank you for the fix!

http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG@10
PS3, Line 10: when FLAGS_block_manager == "logr",
            : opens a data directory will open a RocksDB instance, it
            : consumes more time than that if FLAGS_block_manager == "log".
> It depends on the machine where the test running on, 5 is a good factor on 
Thank you for the clarification.



-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 30 Jul 2024 21:24:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/316/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 21 Jul 2024 10:24:51 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/315/


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 21 Jul 2024 07:46:51 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/345/


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 28 Jul 2024 17:02:24 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21604

to look at the new patch set (#2).

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................

KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Reduce the failure rate of the test by lowering its loop
times. For example, when FLAGS_block_manager == "logr",
opens a data directory will open a RocksDB instance, it
consumes more time than that if FLAGS_block_manager == "log".

Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/21604/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG@10
PS3, Line 10: when FLAGS_block_manager == "logr",
            : opens a data directory will open a RocksDB instance, it
            : consumes more time than that if FLAGS_block_manager == "log".
> Just curious: is factor of 5 is the good estimate in the difference in open
It depends on the machine where the test running on, 5 is a good factor on the current Jenkins machines.

Thanks for the information!
Yes, the mentioned factors "manifest size" can be controlled by the patch https://gerrit.cloudera.org/c/21570/3/src/kudu/fs/dir_manager.cc#352.
The second point "WAL replaying" is meaningless on our use case, because we only use a single column family currently.
The third point "sst file handlers" has a few meaning, but the metadata part of Kudu fs is not supposed to be very large. Maybe I'll add it in another patch.


http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:

http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc@1263
PS3, Line 1263: 1000 : (FLAGS_block_manager == "log" ? 50 : 10);
> If reducing the number of iterations 5-fold when KUDU_ALLOW_SLOW_TESTS is n
The ASAN, TSAN is added (and the value is lowered) when logr initially introduced https://gerrit.cloudera.org/c/18569/, so I decided to remove the confused and complex judgement in PS1. It would be more readable.

It's a "fuzz" test, the loop times doesn't take effect on the correctness. The loop times can be controlled by a flag if some day any body want to control it conveniently.



-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 28 Jul 2024 16:28:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:13:50 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/346/


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 29 Jul 2024 04:26:46 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21604

to look at the new patch set (#3).

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................

KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Reduce the failure rate of the test by lowering its loop
times. For example, when FLAGS_block_manager == "logr",
opens a data directory will open a RocksDB instance, it
consumes more time than that if FLAGS_block_manager == "log".

Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/21604/3
-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/315/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 21 Jul 2024 08:47:26 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG@10
PS3, Line 10: when FLAGS_block_manager == "logr",
            : opens a data directory will open a RocksDB instance, it
            : consumes more time than that if FLAGS_block_manager == "log".
Just curious: is factor of 5 is the good estimate in the difference in opening times there?

BTW, I also found this:
  https://github.com/facebook/rocksdb/wiki/Speed-Up-DB-Open

Maybe, it makes sense evaluating what options from there needs to be available to tweak in Kudu's logr block manager (that might be a follow-up to https://gerrit.cloudera.org/#/c/21570/).

If adding control knobs for some of the options referred, also consider using those recipes to reduce run times of Kudu tests where "logr" block managers is used.  Of course, it's all up to you, as usual.


http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:

http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc@1263
PS3, Line 1263: 1000 : (FLAGS_block_manager == "log" ? 50 : 10);
If reducing the number of iterations 5-fold when KUDU_ALLOW_SLOW_TESTS is not set, maybe it makes sense to do the same when KUDU_ALLOW_SLOW_TESTS is set, reducing the number of iterations from 1000 to 200?



-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 22 Jul 2024 19:23:48 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 5: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/346/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 29 Jul 2024 05:28:48 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/345/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 28 Jul 2024 17:56:07 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/316/


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 21 Jul 2024 09:21:17 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Wang Xixu, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21604

to look at the new patch set (#4).

Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz
......................................................................

KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Reduce the failure rate of the test by lowering its loop
times. For example, when FLAGS_block_manager == "logr",
opens a data directory will open a RocksDB instance, it
consumes more time than that if FLAGS_block_manager == "log".

Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/21604/4
-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] just a test

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: just a test
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/314/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Jul 2024 16:11:38 +0000
Gerrit-HasComments: No

[kudu-CR] just a test

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )

Change subject: just a test
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/314/


-- 
To view, visit http://gerrit.cloudera.org:8080/21604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8
Gerrit-Change-Number: 21604
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Jul 2024 15:09:53 +0000
Gerrit-HasComments: No