You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/07/02 13:12:00 UTC

[GitHub] glynnbird commented on a change in pull request #95: clone user-supplied query string object prior to mutation - issue #85

glynnbird commented on a change in pull request #95: clone user-supplied query string object prior to mutation - issue #85
URL: https://github.com/apache/couchdb-nano/pull/95#discussion_r199491401
 
 

 ##########
 File path: lib/nano.js
 ##########
 @@ -553,6 +553,9 @@ module.exports = exports = nano = function dbScope(cfg) {
       }
       qs = qs || {};
 
+      // prevent mutation of the client qs object by using a clone
+      qs = JSON.parse(JSON.stringify(qs))
 
 Review comment:
   we could. Change on the way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services