You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/27 11:19:56 UTC

[GitHub] [incubator-apisix] Miss-you opened a new issue #1620: [DISCUSS] "config.yaml" supports annotation configuration

Miss-you opened a new issue #1620:
URL: https://github.com/apache/incubator-apisix/issues/1620


   ### Issue description
   
   The current nginx.conf configuration file for apache apisix is generated by `bin/apisix` from the `config.yaml` configuration file, so nginx.conf is best generated by the `bin/apisix` script rather than maintaining a copy itself.
   
   However, the current `bin/apisix` support for generating `nginx.conf` is a generic configuration and does not support some custom or temporary configurations.
   
   It is hoped that `config.yaml` will add an annotation field and that the configuration of this part will be generated directly to the specified location in `nginx.conf`.
   
   Similar practice: in kubernetes-ingress, Ingress configuration has a comment field, where you can fill in large `nginx.conf` custom configurations directly in the comment field, instead of having to implement a piece of code for each field (because some configurations are customized, and it doesn't make sense to leave them to `bin/apisix` implementation, which is not general enough).
   
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):
   * OS:
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] moonming commented on issue #1620: [DISCUSS] "config.yaml" supports annotation configuration

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1620:
URL: https://github.com/apache/incubator-apisix/issues/1620#issuecomment-635876868


   @Miss-you can you show a example about annotation configuration?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on issue #1620: [DISCUSS] "config.yaml" supports annotation configuration

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1620:
URL: https://github.com/apache/incubator-apisix/issues/1620#issuecomment-647844019


   they were the same for users. 
   I want to hide nginx.conf, the personality part should only be in the configuration file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on issue #1620: [DISCUSS] "config.yaml" supports annotation configuration

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1620:
URL: https://github.com/apache/incubator-apisix/issues/1620#issuecomment-647530567


   `bin/apisix` has contained a template already.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] xxm404 commented on issue #1620: [DISCUSS] "config.yaml" supports annotation configuration

Posted by GitBox <gi...@apache.org>.
xxm404 commented on issue #1620:
URL: https://github.com/apache/incubator-apisix/issues/1620#issuecomment-647612147


   > `bin/apisix` has contained a template already.
   
   I mean, APISIX can make `nginx.template` file like `apisix.yaml` in APISIX home directory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on issue #1620: [DISCUSS] "config.yaml" supports annotation configuration

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1620:
URL: https://github.com/apache/incubator-apisix/issues/1620#issuecomment-647099602


   @Miss-you any news?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org