You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "hazendaz (via GitHub)" <gi...@apache.org> on 2023/01/27 00:43:02 UTC
[GitHub] [maven-dependency-plugin] hazendaz opened a new pull request, #285: [fix] Correct invalid property name - should be 'overWriteIfNewer'
hazendaz opened a new pull request, #285:
URL: https://github.com/apache/maven-dependency-plugin/pull/285
was 'overIfNewer'...
note: Have not added Jira yet, looking at a separate issue and this caught my eye as a defect. Other class in copy dependencies has it spelled correctly but without the prefix mdep. Tests all pass so nothing was likely using that, I didn't check further at the moment.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on a diff in pull request #285: [fix] Correct invalid property name - should be 'overWriteIfNewer'
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #285:
URL: https://github.com/apache/maven-dependency-plugin/pull/285#discussion_r1126385896
##########
src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/AbstractFromConfigurationMojo.java:
##########
@@ -79,7 +79,7 @@ public abstract class AbstractFromConfigurationMojo extends AbstractDependencyMo
*
* @since 2.0
*/
- @Parameter(property = "mdep.overIfNewer", defaultValue = "true")
+ @Parameter(property = "mdep.overWriteIfNewer", defaultValue = "true")
Review Comment:
I don't think the property name has to match the field name. This does look like an error but this would be an incompatible change. Thus it needs:
1. A JIRA entry
2. A new property, not just a change
3. Deprecate the old property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org