You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/24 07:42:49 UTC
[GitHub] [incubator-doris] Jibing-Li opened a new pull request, #9190: Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
Jibing-Li opened a new pull request, #9190:
URL: https://github.com/apache/incubator-doris/pull/9190
Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Hive and trino/presto would automatically trim the trailing spaces but Doris doesn't. This would cause different query result with hive.
Describe the overview of changes.
Trim trailing spaces in broker scanner.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (No Need) It has been tested manually.
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9190: Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9190:
URL: https://github.com/apache/incubator-doris/pull/9190#discussion_r873320165
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -442,6 +444,9 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = ENABLE_PROJECTION)
private boolean enableProjection = false;
+ @VariableMgr.VarAttr(name = TRIM_TAILING_SPACES_FOR_EXTERNAL_TABLE_QUERY)
Review Comment:
```suggestion
@VariableMgr.VarAttr(name = TRIM_TAILING_SPACES_FOR_EXTERNAL_TABLE_QUERY, needForward = true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9190: [Fix] Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9190:
URL: https://github.com/apache/incubator-doris/pull/9190#issuecomment-1132365371
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9190: Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9190:
URL: https://github.com/apache/incubator-doris/pull/9190#issuecomment-1118722124
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9190: Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9190:
URL: https://github.com/apache/incubator-doris/pull/9190#issuecomment-1118722072
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9190: [Fix] Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9190:
URL: https://github.com/apache/incubator-doris/pull/9190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9190: [Fix] Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9190:
URL: https://github.com/apache/incubator-doris/pull/9190#issuecomment-1132365389
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org