You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/01 15:46:33 UTC

[GitHub] [flink] XComp commented on a change in pull request #19327: [FLINK-26987][runtime] Fixes getAllAndLock livelock

XComp commented on a change in pull request #19327:
URL: https://github.com/apache/flink/pull/19327#discussion_r840713203



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
##########
@@ -411,8 +410,7 @@ private static boolean isNotMarkedForDeletion(Stat stat) {
                         final RetrievableStateHandle<T> stateHandle = getAndLock(path);
                         stateHandles.add(new Tuple2<>(stateHandle, path));
                     } catch (NotExistException ignored) {
-                        // Concurrent deletion, retry
-                        continue retry;
+                        // entry is subject for deletion and can be ignored

Review comment:
       Good point about the fail fast. I expanded the comment a bit to cover the two case. 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org