You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/01/29 22:38:49 UTC
[GitHub] [datasketches-cpp] AlexanderSaydakov opened a new pull request #189: promoted new implementation of theta sketch
AlexanderSaydakov opened a new pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189
This is a new implementation of theta sketch which shared the base layer with tuple sketch. This version of theta sketch was developed a while ago together with tuple sketch. This pull request is to replace the existing theta sketch with the new version. Serialization was changed: in the new version only compact sketches can be serialized and deserialized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls edited a comment on pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#issuecomment-770093102
## Pull Request Test Coverage Report for [Build 534609581](https://coveralls.io/builds/36837594)
* **84** of **112** **(75.0%)** changed or added relevant lines in **9** files are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.6%**) to **94.406%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [tuple/include/tuple_sketch_impl.hpp](https://coveralls.io/builds/36837594/source?filename=tuple%2Finclude%2Ftuple_sketch_impl.hpp#L241) | 0 | 2 | 0.0%
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36837594/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L60) | 50 | 76 | 65.79%
<!-- | **Total:** | **84** | **112** | **75.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36837594/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L233) | 1 | 31.25% |
| [common/include/conditional_back_inserter.hpp](https://coveralls.io/builds/36837594/source?filename=common%2Finclude%2Fconditional_back_inserter.hpp#L43) | 3 | 53.85% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/36837594) |
| :-- | --: |
| Change from base [Build 521644039](https://coveralls.io/builds/36706668): | 0.6% |
| Covered Lines: | 4523 |
| Relevant Lines: | 4791 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on a change in pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
jmalkin commented on a change in pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#discussion_r569042554
##########
File path: theta/CMakeLists.txt
##########
@@ -33,9 +33,21 @@ target_link_libraries(theta INTERFACE common)
target_compile_features(theta INTERFACE cxx_std_11)
set(theta_HEADERS "")
-list(APPEND theta_HEADERS "include/theta_sketch.hpp;include/theta_union.hpp;include/theta_intersection.hpp")
-list(APPEND theta_HEADERS "include/theta_a_not_b.hpp;include/theta_sketch_impl.hpp")
-list(APPEND theta_HEADERS "include/theta_union_impl.hpp;include/theta_intersection_impl.hpp;include/theta_a_not_b_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_sketch.hpp;include/theta_sketch_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_union.hpp;include/theta_union_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_intersection.hpp;include/theta_intersection_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_a_not_b.hpp;include/theta_a_not_b_impl.hpp")
+list(APPEND tuple_HEADERS "include/theta_jaccard_similarity.hpp")
+list(APPEND tuple_HEADERS "include/theta_comparators.hpp")
Review comment:
should the rest of these be theta_HEADERS rather than tuple?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on a change in pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
jmalkin commented on a change in pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#discussion_r569042554
##########
File path: theta/CMakeLists.txt
##########
@@ -33,9 +33,21 @@ target_link_libraries(theta INTERFACE common)
target_compile_features(theta INTERFACE cxx_std_11)
set(theta_HEADERS "")
-list(APPEND theta_HEADERS "include/theta_sketch.hpp;include/theta_union.hpp;include/theta_intersection.hpp")
-list(APPEND theta_HEADERS "include/theta_a_not_b.hpp;include/theta_sketch_impl.hpp")
-list(APPEND theta_HEADERS "include/theta_union_impl.hpp;include/theta_intersection_impl.hpp;include/theta_a_not_b_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_sketch.hpp;include/theta_sketch_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_union.hpp;include/theta_union_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_intersection.hpp;include/theta_intersection_impl.hpp")
+list(APPEND theta_HEADERS "include/theta_a_not_b.hpp;include/theta_a_not_b_impl.hpp")
+list(APPEND tuple_HEADERS "include/theta_jaccard_similarity.hpp")
+list(APPEND tuple_HEADERS "include/theta_comparators.hpp")
Review comment:
should the rest of these be theta_HEADERS rather than tuple?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls edited a comment on pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#issuecomment-770093102
## Pull Request Test Coverage Report for [Build 522630790](https://coveralls.io/builds/36715763)
* **84** of **112** **(75.0%)** changed or added relevant lines in **9** files are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.6%**) to **94.406%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [tuple/include/tuple_sketch_impl.hpp](https://coveralls.io/builds/36715763/source?filename=tuple%2Finclude%2Ftuple_sketch_impl.hpp#L241) | 0 | 2 | 0.0%
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36715763/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L60) | 50 | 76 | 65.79%
<!-- | **Total:** | **84** | **112** | **75.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36715763/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L233) | 1 | 31.25% |
| [common/include/conditional_back_inserter.hpp](https://coveralls.io/builds/36715763/source?filename=common%2Finclude%2Fconditional_back_inserter.hpp#L43) | 3 | 53.85% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/36715763) |
| :-- | --: |
| Change from base [Build 521644039](https://coveralls.io/builds/36706668): | 0.6% |
| Covered Lines: | 4523 |
| Relevant Lines: | 4791 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls edited a comment on pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#issuecomment-770093102
## Pull Request Test Coverage Report for [Build 522271122](https://coveralls.io/builds/36713468)
* **84** of **112** **(75.0%)** changed or added relevant lines in **9** files are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.5%**) to **94.397%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [tuple/include/tuple_sketch_impl.hpp](https://coveralls.io/builds/36713468/source?filename=tuple%2Finclude%2Ftuple_sketch_impl.hpp#L241) | 0 | 2 | 0.0%
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36713468/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L60) | 50 | 76 | 65.79%
<!-- | **Total:** | **84** | **112** | **75.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36713468/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L233) | 1 | 31.25% |
| [common/include/conditional_back_inserter.hpp](https://coveralls.io/builds/36713468/source?filename=common%2Finclude%2Fconditional_back_inserter.hpp#L43) | 3 | 53.85% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/36713468) |
| :-- | --: |
| Change from base [Build 521644039](https://coveralls.io/builds/36706668): | 0.5% |
| Covered Lines: | 4515 |
| Relevant Lines: | 4783 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls edited a comment on pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#issuecomment-770093102
## Pull Request Test Coverage Report for [Build 522346954](https://coveralls.io/builds/36714004)
* **84** of **112** **(75.0%)** changed or added relevant lines in **9** files are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.6%**) to **94.406%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [tuple/include/tuple_sketch_impl.hpp](https://coveralls.io/builds/36714004/source?filename=tuple%2Finclude%2Ftuple_sketch_impl.hpp#L241) | 0 | 2 | 0.0%
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36714004/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L60) | 50 | 76 | 65.79%
<!-- | **Total:** | **84** | **112** | **75.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36714004/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L233) | 1 | 31.25% |
| [common/include/conditional_back_inserter.hpp](https://coveralls.io/builds/36714004/source?filename=common%2Finclude%2Fconditional_back_inserter.hpp#L43) | 3 | 53.85% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/36714004) |
| :-- | --: |
| Change from base [Build 521644039](https://coveralls.io/builds/36706668): | 0.6% |
| Covered Lines: | 4523 |
| Relevant Lines: | 4791 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
jmalkin commented on pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#issuecomment-773634905
Also, I dunno why the CI build is broken, but it works locally and I'm confident the breakage isn't specific to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
jmalkin commented on pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#issuecomment-773634905
Also, I dunno why the CI build is broken, but it works locally and I'm confident the breakage isn't specific to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #189: promoted new implementation of theta sketch
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #189:
URL: https://github.com/apache/datasketches-cpp/pull/189#issuecomment-770093102
## Pull Request Test Coverage Report for [Build 522198724](https://coveralls.io/builds/36712803)
* **84** of **112** **(75.0%)** changed or added relevant lines in **9** files are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.5%**) to **94.397%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [tuple/include/tuple_sketch_impl.hpp](https://coveralls.io/builds/36712803/source?filename=tuple%2Finclude%2Ftuple_sketch_impl.hpp#L241) | 0 | 2 | 0.0%
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36712803/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L60) | 50 | 76 | 65.79%
<!-- | **Total:** | **84** | **112** | **75.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/36712803/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L233) | 1 | 31.25% |
| [common/include/conditional_back_inserter.hpp](https://coveralls.io/builds/36712803/source?filename=common%2Finclude%2Fconditional_back_inserter.hpp#L43) | 3 | 53.85% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/36712803) |
| :-- | --: |
| Change from base [Build 521644039](https://coveralls.io/builds/36706668): | 0.5% |
| Covered Lines: | 4515 |
| Relevant Lines: | 4783 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org