You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/08/05 08:21:45 UTC
[GitHub] [jena] rvesse opened a new pull request #779: JENA-1939: fix getUpdateCount() in the JDBC driver
rvesse opened a new pull request #779:
URL: https://github.com/apache/jena/pull/779
The method JenaStatement.getUpdateCount() returns 0. But java.sql.Statement documentation says:
Returns: the current result as an update count; -1 if the current result is a ResultSet object or there are no more results
Returning correct value is important because a single statement may have multiple result sets and cause mutiple updates (not only multiple updated records, but multiple sets of updated records).
Applications (e.g. SQL-DK) iterate over these multiple results and need to know when finish. The getMoreResults() documentation says:
There are no more results when the following is true: ((stmt.getMoreResults() == false) && (stmt.getUpdateCount() == -1))
But if 0 is returned, the application enters infinite loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on pull request #779: JENA-1939: fix getUpdateCount() in the JDBC driver
Posted by GitBox <gi...@apache.org>.
rvesse commented on pull request #779:
URL: https://github.com/apache/jena/pull/779#issuecomment-669056810
This LGTM as far as I can tell, been a long time since I looked at the JDBC stuff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse merged pull request #779: JENA-1939: fix getUpdateCount() in the JDBC driver
Posted by GitBox <gi...@apache.org>.
rvesse merged pull request #779:
URL: https://github.com/apache/jena/pull/779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org