You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "mlycore (via GitHub)" <gi...@apache.org> on 2023/04/28 10:26:44 UTC

[GitHub] [shardingsphere-on-cloud] mlycore opened a new pull request, #333: fix(operator): fix configmap and job creation error while no shardingspherechaos is found

mlycore opened a new pull request, #333:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/333

   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Test is required for the feat/fix PR, unless you have a good reason
   2. Doc is required for the feat PR
   3. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #333: fix(operator): fix configmap and job creation error while no shardingspherechaos is found

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #333:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/333#issuecomment-1527342576

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=333)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=333&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=333) No Coverage information  
   [![2.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '2.5%')](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=333&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=333&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #333: fix(operator): fix configmap and job creation error while no shardingspherechaos is found

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #333:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/333#issuecomment-1527349884

   ## [Codecov](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#333](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cfbd7b) into [main](https://codecov.io/gh/apache/shardingsphere-on-cloud/commit/095d94c89787d4f070e4c6a76148329b1270551d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (095d94c) will **decrease** coverage by `12.83%`.
   > The diff coverage is `1.57%`.
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #333       +/-   ##
   ===========================================
   - Coverage   45.99%   33.16%   -12.83%     
   ===========================================
     Files          20       34       +14     
     Lines        1698     3419     +1721     
   ===========================================
   + Hits          781     1134      +353     
   - Misses        832     2225     +1393     
   + Partials       85       60       -25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ator/cmd/shardingsphere-operator/manager/option.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvY21kL3NoYXJkaW5nc3BoZXJlLW9wZXJhdG9yL21hbmFnZXIvb3B0aW9uLmdv) | `51.68% <0.00%> (ø)` | |
   | [...perator/pkg/controllers/compute\_node\_controller.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL2NvbXB1dGVfbm9kZV9jb250cm9sbGVyLmdv) | `6.72% <0.00%> (ø)` | |
   | [...pkg/controllers/shardingsphere\_chaos\_controller.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3NoYXJkaW5nc3BoZXJlX2NoYW9zX2NvbnRyb2xsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
   | [...phere-operator/pkg/kubernetes/configmap/builder.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2t1YmVybmV0ZXMvY29uZmlnbWFwL2J1aWxkZXIuZ28=) | `52.85% <ø> (ø)` | |
   | [...e-operator/pkg/kubernetes/deployment/deployment.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2t1YmVybmV0ZXMvZGVwbG95bWVudC9kZXBsb3ltZW50Lmdv) | `0.00% <0.00%> (ø)` | |
   | [...gsphere-operator/pkg/kubernetes/service/buidler.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2t1YmVybmV0ZXMvc2VydmljZS9idWlkbGVyLmdv) | `100.00% <ø> (ø)` | |
   | [...gsphere-operator/pkg/kubernetes/service/service.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2t1YmVybmV0ZXMvc2VydmljZS9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [...tor/pkg/reconcile/shardingspherechaos/configmap.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zaGFyZGluZ3NwaGVyZWNoYW9zL2NvbmZpZ21hcC5nbw==) | `0.00% <0.00%> (ø)` | |
   | [...-operator/pkg/reconcile/shardingspherechaos/job.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zaGFyZGluZ3NwaGVyZWNoYW9zL2pvYi5nbw==) | `0.00% <0.00%> (ø)` | |
   | [...ere-operator/pkg/kubernetes/configmap/configmap.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2t1YmVybmV0ZXMvY29uZmlnbWFwL2NvbmZpZ21hcC5nbw==) | `38.46% <36.36%> (ø)` | |
   | ... and [1 more](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ... and [23 files with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/333/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] strongduanmu merged pull request #333: fix(operator): fix configmap and job creation error while no shardingspherechaos is found

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #333:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org