You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by concretevitamin <gi...@git.apache.org> on 2014/06/07 02:05:29 UTC

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

GitHub user concretevitamin opened a pull request:

    https://github.com/apache/spark/pull/1003

    [SPARK-1704][SQL] Fully support EXPLAIN commands as SchemaRDD.

    This PR attempts to resolve [SPARK-1704](https://issues.apache.org/jira/browse/SPARK-1704) by introducing a physical plan for EXPLAIN commands, which just prints out the debug string (containing various SparkSQL's plans) of the corresponding QueryExecution for the actual query.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/concretevitamin/spark explain-cmd

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1003
    
----
commit 408f574fd17730362dac0a6b966d4470df71cc1c
Author: Zongheng Yang <zo...@gmail.com>
Date:   2014-06-06T20:51:06Z

    SPARK-1704: Add CommandStrategy and ExplainCommandPhysical.

commit 439c6abb689b3859a63ec2b850586b362dc3a3a1
Author: Zongheng Yang <zo...@gmail.com>
Date:   2014-06-07T00:02:45Z

    Minor cleanups.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/1003


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45402904
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45403070
  
    This might not be your problem, but when I tried the following, I got ...
    ```
    scala> c.hql("explain select key, count(value) from src group by key").collect()
    14/06/06 23:58:05 INFO parse.ParseDriver: Parsing command: explain select key, count(value) from src group by key
    14/06/06 23:58:05 INFO parse.ParseDriver: Parse Completed
    14/06/06 23:58:05 INFO analysis.Analyzer: Max iterations (2) reached for batch MultiInstanceRelations
    14/06/06 23:58:05 INFO analysis.Analyzer: Max iterations (2) reached for batch CaseInsensitiveAttributeReferences
    14/06/06 23:58:05 INFO analysis.Analyzer: Max iterations (2) reached for batch MultiInstanceRelations
    14/06/06 23:58:05 INFO analysis.Analyzer: Max iterations (2) reached for batch CaseInsensitiveAttributeReferences
    14/06/06 23:58:05 INFO metastore.HiveMetaStore: 0: get_table : db=default tbl=src
    14/06/06 23:58:05 INFO HiveMetaStore.audit: ugi=rxin	ip=unknown-ip-addr	cmd=get_table : db=default tbl=src	
    14/06/06 23:58:05 INFO storage.MemoryStore: ensureFreeSpace(147699) called with curMem=737503, maxMem=1145674137
    14/06/06 23:58:05 INFO storage.MemoryStore: Block broadcast_5 stored as values to memory (estimated size 144.2 KB, free 1091.8 MB)
    14/06/06 23:58:05 INFO sql.SQLContext$$anon$1: Max iterations (2) reached for batch Add exchange
    14/06/06 23:58:05 INFO sql.SQLContext$$anon$1: Max iterations (2) reached for batch Prepare Expressions
    org.apache.spark.sql.catalyst.errors.package$TreeNodeException: makeCopy, tree:
    ExplainCommandPhysical 
     Aggregate false, [key#12], [key#12,SUM(PartialCount#14L) AS c_1#10L]
      Exchange (HashPartitioning [key#12:0], 150)
       Aggregate true, [key#12], [key#12,COUNT(value#13) AS PartialCount#14L]
        HiveTableScan [key#12,value#13], (MetastoreRelation default, src, None), None
    
    	at org.apache.spark.sql.catalyst.errors.package$.attachTree(package.scala:47)
    	at org.apache.spark.sql.catalyst.trees.TreeNode.makeCopy(TreeNode.scala:265)
    	at org.apache.spark.sql.catalyst.trees.TreeNode.transformChildrenUp(TreeNode.scala:249)
    	at org.apache.spark.sql.catalyst.trees.TreeNode.transformUp(TreeNode.scala:215)
    	at org.apache.spark.sql.execution.AddExchange$.apply(Exchange.scala:93)
    	at org.apache.spark.sql.execution.AddExchange$.apply(Exchange.scala:89)
    	at org.apache.spark.sql.catalyst.rules.RuleExecutor$$anonfun$apply$1$$anonfun$apply$2.apply(RuleExecutor.scala:62)
    	at org.apache.spark.sql.catalyst.rules.RuleExecutor$$anonfun$apply$1$$anonfun$apply$2.apply(RuleExecutor.scala:60)
    	at scala.collection.IndexedSeqOptimized$class.foldl(IndexedSeqOptimized.scala:51)
    	at scala.collection.IndexedSeqOptimized$class.foldLeft(IndexedSeqOptimized.scala:60)
    	at scala.collection.mutable.WrappedArray.foldLeft(WrappedArray.scala:34)
    	at org.apache.spark.sql.catalyst.rules.RuleExecutor$$anonfun$apply$1.apply(RuleExecutor.scala:60)
    	at org.apache.spark.sql.catalyst.rules.RuleExecutor$$anonfun$apply$1.apply(RuleExecutor.scala:52)
    	at scala.collection.immutable.List.foreach(List.scala:318)
    	at org.apache.spark.sql.catalyst.rules.RuleExecutor.apply(RuleExecutor.scala:52)
    	at org.apache.spark.sql.SQLContext$QueryExecution.executedPlan$lzycompute(SQLContext.scala:275)
    	at org.apache.spark.sql.SQLContext$QueryExecution.executedPlan(SQLContext.scala:275)
    	at org.apache.spark.sql.hive.HiveContext$QueryExecution.toRdd$lzycompute(HiveContext.scala:260)
    	at org.apache.spark.sql.hive.HiveContext$QueryExecution.toRdd(HiveContext.scala:248)
    	at org.apache.spark.sql.hive.HiveContext.hiveql(HiveContext.scala:85)
    	at org.apache.spark.sql.hive.HiveContext.hql(HiveContext.scala:90)
    	at $i$$$$9579e5b89ab1eb428704b684e2e341c$$$$$.<init>(<console>:70)
    	at $i$$$$9579e5b89ab1eb428704b684e2e341c$$$$$.<clinit>(<console>)
    	at .<init>(<console>:7)
    	at .<clinit>(<console>)
    	at $print(<console>)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:606)
    	at scala.tools.nsc.interpreter.IMain$ReadEvalPrint.call(IMain.scala:734)
    	at scala.tools.nsc.interpreter.IMain$Request.loadAndRun(IMain.scala:983)
    	at scala.tools.nsc.interpreter.IMain.loadAndRunReq$1(IMain.scala:573)
    	at scala.tools.nsc.interpreter.IMain.interpret(IMain.scala:604)
    	at scala.tools.nsc.interpreter.IMain.interpret(IMain.scala:568)
    	at scala.tools.nsc.interpreter.ILoop.reallyInterpret$1(ILoop.scala:760)
    	at scala.tools.nsc.interpreter.ILoop.interpretStartingWith(ILoop.scala:805)
    	at scala.tools.nsc.interpreter.ILoop.command(ILoop.scala:717)
    	at scala.tools.nsc.interpreter.ILoop.processLine$1(ILoop.scala:581)
    	at scala.tools.nsc.interpreter.ILoop.innerLoop$1(ILoop.scala:588)
    	at scala.tools.nsc.interpreter.ILoop.loop(ILoop.scala:591)
    	at scala.tools.nsc.interpreter.ILoop$$anonfun$process$1.apply$mcZ$sp(ILoop.scala:882)
    	at scala.tools.nsc.interpreter.ILoop$$anonfun$process$1.apply(ILoop.scala:837)
    	at scala.tools.nsc.interpreter.ILoop$$anonfun$process$1.apply(ILoop.scala:837)
    	at scala.tools.nsc.util.ScalaClassLoader$.savingContextLoader(ScalaClassLoader.scala:135)
    	at scala.tools.nsc.interpreter.ILoop.process(ILoop.scala:837)
    	at scala.tools.nsc.interpreter.ILoop.main(ILoop.scala:904)
    	at xsbt.ConsoleInterface.run(ConsoleInterface.scala:69)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:606)
    	at sbt.compiler.AnalyzingCompiler.call(AnalyzingCompiler.scala:102)
    	at sbt.compiler.AnalyzingCompiler.console(AnalyzingCompiler.scala:77)
    	at sbt.Console.sbt$Console$$console0$1(Console.scala:23)
    	at sbt.Console$$anonfun$apply$2$$anonfun$apply$1.apply$mcV$sp(Console.scala:24)
    	at sbt.Console$$anonfun$apply$2$$anonfun$apply$1.apply(Console.scala:24)
    	at sbt.Console$$anonfun$apply$2$$anonfun$apply$1.apply(Console.scala:24)
    	at sbt.Logger$$anon$4.apply(Logger.scala:90)
    	at sbt.TrapExit$App.run(TrapExit.scala:244)
    	at java.lang.Thread.run(Thread.java:744)
    Caused by: org.apache.spark.sql.catalyst.errors.package$TreeNodeException: Failed to copy node.  Is otherCopyArgs specified correctly for ExplainCommandPhysical?, tree:
    ExplainCommandPhysical 
     Aggregate false, [key#12], [key#12,SUM(PartialCount#14L) AS c_1#10L]
      Exchange (HashPartitioning [key#12:0], 150)
       Aggregate true, [key#12], [key#12,COUNT(value#13) AS PartialCount#14L]
        HiveTableScan [key#12,value#13], (MetastoreRelation default, src, None), None
    
    	at org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$makeCopy$1.apply(TreeNode.scala:275)
    	at org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$makeCopy$1.apply(TreeNode.scala:266)
    	at org.apache.spark.sql.catalyst.errors.package$.attachTree(package.scala:46)
    	... 60 more
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by concretevitamin <gi...@git.apache.org>.
Github user concretevitamin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1003#discussion_r13518362
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution
    +
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.sql.{SQLContext, Row}
    +import org.apache.spark.sql.catalyst.expressions.{GenericRow, Attribute}
    +
    +case class ExplainCommandPhysical(child: SparkPlan)
    +                                 (@transient context: SQLContext) extends UnaryNode {
    +  def execute(): RDD[Row] = {
    +    val lines = child.toString.split("\n").map(s => new GenericRow(Array[Any](s)))
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by concretevitamin <gi...@git.apache.org>.
Github user concretevitamin commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45531093
  
    I added a test which is passing in this branch but failing in master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1003#discussion_r13571347
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -255,6 +256,11 @@ class SQLContext(@transient val sparkContext: SparkContext)
           Batch("Prepare Expressions", Once, new BindReferences[SparkPlan]) :: Nil
       }
     
    +  // TODO: or should we make QueryExecution protected[sql]?
    +  protected[sql] def mkQueryExecution(plan: LogicalPlan) = new QueryExecution {
    --- End diff --
    
    This method already exists above as `executePlan`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by qiaohaijun <gi...@git.apache.org>.
Github user qiaohaijun commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-61446141
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45416324
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45404338
  
    All automated tests passed.
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15523/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45397729
  
    Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45545688
  
    Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45558701
  
    Merged into 1.0 and master.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45406570
  
    > `Caused by: org.apache.spark.sql.catalyst.errors.package$TreeNodeException: Failed to copy node.  Is otherCopyArgs specified correctly for ExplainCommandPhysical?, tree:`
    
    Second parameter lists aren't automatically copied.  You'll need to add `override def otherCopyArgs = sc :: Nil`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45418220
  
    Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by concretevitamin <gi...@git.apache.org>.
Github user concretevitamin commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45416271
  
    Fixed. Additionally, should `output` be a single column of something like "plan" w/ StringType?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45545692
  
    All automated tests passed.
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15573/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45416340
  
    Yes, that sounds reasonable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45418221
  
    All automated tests passed.
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15528/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1003#discussion_r13518233
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution
    +
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.sql.{SQLContext, Row}
    +import org.apache.spark.sql.catalyst.expressions.{GenericRow, Attribute}
    +
    +case class ExplainCommandPhysical(child: SparkPlan)
    +                                 (@transient context: SQLContext) extends UnaryNode {
    +  def execute(): RDD[Row] = {
    +    val lines = child.toString.split("\n").map(s => new GenericRow(Array[Any](s)))
    --- End diff --
    
    seems a little bit strange to have one row per row ... I think the plan should be a single value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45531356
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45395535
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45397730
  
    All automated tests passed.
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15520/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45537267
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45395532
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45416328
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45417101
  
    Can you add a test case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45404337
  
    Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-1704][SQL] Fully support EXPLAIN comman...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1003#issuecomment-45402909
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---