You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Alex Parvulescu (Created) (JIRA)" <ji...@apache.org> on 2011/12/01 15:22:40 UTC
[jira] [Created] (JCR-3165) Consolidate compare behaviour for
Value(s) and Comparable(s)
Consolidate compare behaviour for Value(s) and Comparable(s)
------------------------------------------------------------
Key: JCR-3165
URL: https://issues.apache.org/jira/browse/JCR-3165
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: query
Reporter: Alex Parvulescu
Priority: Minor
There are 2 different implementations of Value comparison (ValueComparator and Util). With the introduction of JCR-2906 which introduces arrays into the mix, I'd like to refactor all of them into one place, namely o.a.j.core.query.lucene.Util.
This will also allow for a wider scope of comparison for Value[], marked as TODO in the ValueComparator class.
Will attach patch shortly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3165) Consolidate compare behaviour for
Value(s) and Comparable(s)
Posted by "Alex Parvulescu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu updated JCR-3165:
---------------------------------
Attachment: JCR-3165.patch
proposed patch
> Consolidate compare behaviour for Value(s) and Comparable(s)
> ------------------------------------------------------------
>
> Key: JCR-3165
> URL: https://issues.apache.org/jira/browse/JCR-3165
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: query
> Reporter: Alex Parvulescu
> Priority: Minor
> Attachments: JCR-3165.patch
>
>
> There are 2 different implementations of Value comparison (ValueComparator and Util). With the introduction of JCR-2906 which introduces arrays into the mix, I'd like to refactor all of them into one place, namely o.a.j.core.query.lucene.Util.
> This will also allow for a wider scope of comparison for Value[], marked as TODO in the ValueComparator class.
> Will attach patch shortly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3165) Consolidate compare behaviour for
Value(s) and Comparable(s)
Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161543#comment-13161543 ]
Alex Parvulescu commented on JCR-3165:
--------------------------------------
Cool, thanks for the feedback Michael!
I agree that Utils could use some refactoring as well :) maybe next time.
I'll apply the patch shortly
> Consolidate compare behaviour for Value(s) and Comparable(s)
> ------------------------------------------------------------
>
> Key: JCR-3165
> URL: https://issues.apache.org/jira/browse/JCR-3165
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: query
> Reporter: Alex Parvulescu
> Priority: Minor
> Attachments: JCR-3165.patch
>
>
> There are 2 different implementations of Value comparison (ValueComparator and Util). With the introduction of JCR-2906 which introduces arrays into the mix, I'd like to refactor all of them into one place, namely o.a.j.core.query.lucene.Util.
> This will also allow for a wider scope of comparison for Value[], marked as TODO in the ValueComparator class.
> Will attach patch shortly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3165) Consolidate compare behaviour for
Value(s) and Comparable(s)
Posted by "Alex Parvulescu (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu resolved JCR-3165.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.3.5
fixed in revision: 1209402
> Consolidate compare behaviour for Value(s) and Comparable(s)
> ------------------------------------------------------------
>
> Key: JCR-3165
> URL: https://issues.apache.org/jira/browse/JCR-3165
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: query
> Reporter: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.5
>
> Attachments: JCR-3165.patch
>
>
> There are 2 different implementations of Value comparison (ValueComparator and Util). With the introduction of JCR-2906 which introduces arrays into the mix, I'd like to refactor all of them into one place, namely o.a.j.core.query.lucene.Util.
> This will also allow for a wider scope of comparison for Value[], marked as TODO in the ValueComparator class.
> Will attach patch shortly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3165) Consolidate compare behaviour for
Value(s) and Comparable(s)
Posted by "Michael Dürig (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161533#comment-13161533 ]
Michael Dürig commented on JCR-3165:
------------------------------------
Looks good to me. I quickly applied the patch and all tests passed. The only thing we could probably do is to move all comparison related methods from the Utils class to a dedicated utility class. I'm not too sure about this however.
> Consolidate compare behaviour for Value(s) and Comparable(s)
> ------------------------------------------------------------
>
> Key: JCR-3165
> URL: https://issues.apache.org/jira/browse/JCR-3165
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: query
> Reporter: Alex Parvulescu
> Priority: Minor
> Attachments: JCR-3165.patch
>
>
> There are 2 different implementations of Value comparison (ValueComparator and Util). With the introduction of JCR-2906 which introduces arrays into the mix, I'd like to refactor all of them into one place, namely o.a.j.core.query.lucene.Util.
> This will also allow for a wider scope of comparison for Value[], marked as TODO in the ValueComparator class.
> Will attach patch shortly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira