You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Arpit Agarwal (JIRA)" <ji...@apache.org> on 2013/09/28 01:58:02 UTC
[jira] [Updated] (HDFS-5272) DFSUtil#getInfoServer cleanup
[ https://issues.apache.org/jira/browse/HDFS-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Agarwal updated HDFS-5272:
--------------------------------
Description:
The {{httpsAddress}} parameter is not used outside of tests.
{code}
public static String getInfoServer(InetSocketAddress namenodeAddr,
Configuration conf, boolean httpsAddress) throws IOException {
boolean securityOn = UserGroupInformation.isSecurityEnabled();
String httpAddressKey = (securityOn && httpsAddress) ?
DFS_NAMENODE_HTTPS_ADDRESS_KEY : DFS_NAMENODE_HTTP_ADDRESS_KEY;
String httpAddressDefault = (securityOn && httpsAddress) ?
DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT : DFS_NAMENODE_HTTP_ADDRESS_DEFAULT;
{code}
[~jingzhao] confirmed on HDFS-5271 that DFS_NAMENODE_HTTP_ADDRESS_DEFAULT will be the default that is always available so there should be no reason to choose betwen DFS_NAMENODE_HTTP_ADDRESS_DEFAULT and DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT. Filing Jira to clean this up.
was:
The {{httpsAddress}} parameter is not used outside of tests.
{code}
public static String getInfoServer(InetSocketAddress namenodeAddr,
Configuration conf, boolean httpsAddress) throws IOException {
boolean securityOn = UserGroupInformation.isSecurityEnabled();
String httpAddressKey = (securityOn && httpsAddress) ?
DFS_NAMENODE_HTTPS_ADDRESS_KEY : DFS_NAMENODE_HTTP_ADDRESS_KEY;
String httpAddressDefault = (securityOn && httpsAddress) ?
DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT : DFS_NAMENODE_HTTP_ADDRESS_DEFAULT;
{code}
It sounds DFS_NAMENODE_HTTP_ADDRESS_DEFAULT is going to be the default that is always available so there should be no reason to use DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT. Filing Jira to clear this up.
> DFSUtil#getInfoServer cleanup
> -----------------------------
>
> Key: HDFS-5272
> URL: https://issues.apache.org/jira/browse/HDFS-5272
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Arpit Agarwal
>
> The {{httpsAddress}} parameter is not used outside of tests.
> {code}
> public static String getInfoServer(InetSocketAddress namenodeAddr,
> Configuration conf, boolean httpsAddress) throws IOException {
> boolean securityOn = UserGroupInformation.isSecurityEnabled();
> String httpAddressKey = (securityOn && httpsAddress) ?
> DFS_NAMENODE_HTTPS_ADDRESS_KEY : DFS_NAMENODE_HTTP_ADDRESS_KEY;
> String httpAddressDefault = (securityOn && httpsAddress) ?
> DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT : DFS_NAMENODE_HTTP_ADDRESS_DEFAULT;
> {code}
> [~jingzhao] confirmed on HDFS-5271 that DFS_NAMENODE_HTTP_ADDRESS_DEFAULT will be the default that is always available so there should be no reason to choose betwen DFS_NAMENODE_HTTP_ADDRESS_DEFAULT and DFS_NAMENODE_HTTPS_ADDRESS_DEFAULT. Filing Jira to clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira