[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5344: Change default metrics reporter to prometheus

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #5344:
URL: https://github.com/apache/kyuubi/pull/5344#discussion_r1340000715


##########
docs/deployment/migration-guide.md:
##########
@@ -19,38 +19,55 @@
 
 ## Upgrading from Kyuubi 1.7 to 1.8
 
-* Since Kyuubi 1.8, SQLite is added and becomes the default database type of Kyuubi metastore, as Derby has been deprecated.
+* Since Kyuubi 1.8, SQLite is added and becomes the default database type of Kyuubi metastore, as Derby has been
+  deprecated.
   Both Derby and SQLite are mainly for testing purposes, and they're not supposed to be used in production.
   To restore previous behavior, set `kyuubi.metadata.store.jdbc.database.type=DERBY` and
   `kyuubi.metadata.store.jdbc.url=jdbc:derby:memory:kyuubi_state_store_db;create=true`.
 
+* Since Kyuubi 1.8, PROMETHEUS is changed as the default metrics reporter, because PROMETHEUS is a popular and widely

Review Comment:
   we don't need to mention "because ..." 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org