[jspwiki] 04/08: apply suggested fixes by intellij

[ju...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

juanpablo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jspwiki.git

commit 3067429be7de4edbb183405ca76e213466740fc4
Author: juanpablo <ju...@apache.org>
AuthorDate: Wed Sep 30 22:33:48 2020 +0200

    apply suggested fixes by intellij
---
 .../src/main/java/org/apache/wiki/pages/Page.java          | 14 +++++++-------
 .../src/main/java/org/apache/wiki/pages/PageBuilder.java   |  5 ++---
 .../main/java/org/apache/wiki/pages/haddock/LoginPage.java |  5 ++---
 3 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/Page.java b/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/Page.java
index f178b9d..f7b0d1d 100644
--- a/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/Page.java
+++ b/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/Page.java
@@ -18,19 +18,19 @@
  */
 package org.apache.wiki.pages;
 
-import java.io.File;
-import java.io.IOException;
-
-import org.apache.wiki.its.environment.Env;
-
 import com.codeborne.selenide.Selenide;
 import com.codeborne.selenide.WebDriverRunner;
+import org.apache.wiki.its.environment.Env;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URISyntaxException;
 
 
 /**
  * Common operations for Page Objects.
  * 
- * @see https://selenide.gitbooks.io/user-guide/content/en/pageobjects.html
+ * @see <a href="https://selenide.gitbooks.io/user-guide/content/en/pageobjects.html">Page Objects</a>
  */
 public interface Page {
 
@@ -53,7 +53,7 @@ public interface Page {
         return Env.TESTS_BASE_URL;
     }
     
-    static File download( String url ) throws IOException {
+    static File download( final String url ) throws IOException, URISyntaxException {
         return Selenide.download( url );
     }
 
diff --git a/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/PageBuilder.java b/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/PageBuilder.java
index dbf1e5e..27f6ee5 100644
--- a/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/PageBuilder.java
+++ b/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/PageBuilder.java
@@ -18,10 +18,9 @@
  */
 package org.apache.wiki.pages;
 
-import org.apache.wiki.its.environment.Env;
-
 import com.codeborne.selenide.Configuration;
 import com.codeborne.selenide.Selenide;
+import org.apache.wiki.its.environment.Env;
 
 
 /**
@@ -40,7 +39,7 @@ public class PageBuilder {
     /**
      * Sets up Selenide and opens the requested URL, allowing chaining additional operations over the given {@link Page} instance.
      *
-     * @param cls {@link Page} instance, in order to allow chaining operations.
+     * @param page {@link Page} instance, in order to allow chaining operations.
      * @return {@link Page} instance given on the {@link PageBuilder} constructor.
      */
     public < T extends Page > T openAs( final T page ) {
diff --git a/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/haddock/LoginPage.java b/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/haddock/LoginPage.java
index 4ff7655..c080dfd 100644
--- a/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/haddock/LoginPage.java
+++ b/jspwiki-it-tests/jspwiki-selenide-tests/src/main/java/org/apache/wiki/pages/haddock/LoginPage.java
@@ -18,18 +18,17 @@
  */
 package org.apache.wiki.pages.haddock;
 
+import com.codeborne.selenide.Selenide;
 import org.apache.wiki.its.environment.Env;
 import org.openqa.selenium.By;
 
-import com.codeborne.selenide.Selenide;
-
 public class LoginPage implements HaddockPage {
     
     public ReadWikiPage performLogin() {
         return performLogin( Env.LOGIN_JANNE_USERNAME, Env.LOGIN_JANNE_PASSWORD );
     }
     
-    public ReadWikiPage performLogin( String login, String password ) {
+    public ReadWikiPage performLogin( final String login, final String password ) {
         Selenide.$( By.id( "j_username" ) ).val( login );
         Selenide.$( By.id( "j_password" ) ).val( password );
         Selenide.$( By.name( "submitlogin" ) ).click();