You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/09 21:56:57 UTC

[GitHub] [incubator-mxnet] zachgk commented on a change in pull request #17027: Merge make/pip and make/maven configurations

zachgk commented on a change in pull request #17027: Merge make/pip and make/maven configurations
URL: https://github.com/apache/incubator-mxnet/pull/17027#discussion_r355707220
 
 

 ##########
 File path: tools/staticbuild/build_lib.sh
 ##########
 @@ -18,7 +18,7 @@
 # under the License.
 
 # This script builds the libraries of mxnet.
-make_config=make/${STATIC_BUILD_TARGET}/${STATIC_BUILD_TARGET}_${PLATFORM}_${VARIANT}.mk
+make_config=make/${STATIC_BUILD_TARGET}/${PLATFORM}_${VARIANT}.mk
 
 Review comment:
   I think this might be better because it would be easier if there is a difference in the future or if another language binding uses this build but needs changes to the configuration

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services