You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/24 15:35:15 UTC
[GitHub] [incubator-doris] imay opened a new pull request #4182: #4181 Let linked-schema change work for BETA tablet
imay opened a new pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on pull request #4182: #4181 Let linked-schema change work for BETA tablet
Posted by GitBox <gi...@apache.org>.
chaoyli commented on pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182#issuecomment-665626104
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4182: #4181 Let linked-schema change work for BETA tablet
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182#issuecomment-663829847
Please add an ISSUE to describe the problem you fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on pull request #4182: #4181 Let linked-schema change work for BETA tablet
Posted by GitBox <gi...@apache.org>.
imay commented on pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182#issuecomment-664076127
> Please add an ISSUE to describe the problem you fixed.
Issue is in the commit title
#4181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #4182: #4181 Let linked-schema change work for BETA tablet
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182#issuecomment-663793293
We should cover the schema_version_convert in UT, which is error-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4182: #4181 Let linked-schema change work for BETA tablet
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182#discussion_r460350162
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -2141,7 +2141,7 @@ OLAPStatus SchemaChangeHandler::_parse_request(TabletSharedPtr base_tablet,
*sc_directly = true;
}
- if (new_tablet->tablet_meta()->preferred_rowset_type() == BETA_ROWSET) {
+ if (base_tablet->tablet_meta()->preferred_rowset_type() != new_tablet->tablet_meta()->preferred_rowset_type()) {
Review comment:
The comment need update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4182: #4181 Let linked-schema change work for BETA tablet
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4182:
URL: https://github.com/apache/incubator-doris/pull/4182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org