[GitHub] [arrow] kou commented on a change in pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#discussion_r501393657



##########
File path: python/pyproject.toml
##########
@@ -19,7 +19,9 @@
 requires = [
     "cython >= 0.29",
     "numpy==1.14.5; python_version<'3.7'",
-    "numpy==1.16.0; python_version>='3.7'",

Review comment:
       > but it probably can accept 1.19.2 which I'm not sure if it's the first release to support Python 3.9
   
   How about confirming it with CI?

##########
File path: dev/tasks/python-wheels/win-build.bat
##########
@@ -110,6 +110,6 @@ set ARROW_TEST_DATA=%ARROW_SRC%\testing\data
 %PYTHON_INTERPRETER% -c "import pyarrow.dataset" || exit /B
 
 @rem run the python tests, but disable the cython because there is a linking
-@rem issue on python 3.8
+@rem issue on python 3.9
 set PYARROW_TEST_CYTHON=OFF

Review comment:
       How about confirming it with CI?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org