[jira] [Commented] (ZOOKEEPER-1232) remove unused o.a.z.server.util.Profiler

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141341#comment-13141341 ] 

Hadoop QA commented on ZOOKEEPER-1232:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501794/ZOOKEEPER-1232.patch
  against trunk revision 1196025.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/755//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/755//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/755//console

This message is automatically generated.
                
> remove unused o.a.z.server.util.Profiler
> ----------------------------------------
>
>                 Key: ZOOKEEPER-1232
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1232
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Minor
>         Attachments: ZOOKEEPER-1232.patch
>
>
> The class is not used and it rather harms to suggest to people that this would be the right way to do micro-benchmarks on the JVM. It even harms to suggest that micro-benchmarks are the right way to approach Java performance issues.
> Quote from http://code.google.com/p/caliper/wiki/JavaMicrobenchmarks
> "Why would I ever write a microbenchmark then?
> Most of the time, you shouldn't! Instead, slavishly follow a principle of simple, clear coding that avoids clever optimizations. This is the type of code that JITs of the present and future are most likely to know how to optimize themselves. And that's a job which truly should be theirs, not yours. "
> Tools to do microbenchmarks:
> http://code.google.com/p/caliper/ (from the team that also does Guava, the Google Java library, recommended by Joshua Bloch himself)
> http://hype-free.blogspot.com/2010/01/choosing-java-profiler.html
> http://www.infoq.com/articles/java-profiling-with-open-source
> http://java.net/projects/japex
> Joshua Bloch on Performance Anxiety:
> http://java.dzone.com/articles/joshua-bloch-performance (follow link to parleys)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira