You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2017/09/21 19:46:11 UTC
mesos git commit: Fixed a javascript lint issue related to ellipsis
in the webui.
Repository: mesos
Updated Branches:
refs/heads/master 8c4533623 -> 3e25168c3
Fixed a javascript lint issue related to ellipsis in the webui.
We were previously using non-printable characters which
is an issue for the JavaScript linter we plan to use.
Review: https://reviews.apache.org/r/62434/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/3e25168c
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/3e25168c
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/3e25168c
Branch: refs/heads/master
Commit: 3e25168c3820a93e9ce89026c73d55e5614f2f7e
Parents: 8c45336
Author: Armand Grillet <ag...@mesosphere.io>
Authored: Thu Sep 21 12:42:53 2017 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Thu Sep 21 12:46:03 2017 -0700
----------------------------------------------------------------------
src/webui/master/static/js/app.js | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/3e25168c/src/webui/master/static/js/app.js
----------------------------------------------------------------------
diff --git a/src/webui/master/static/js/app.js b/src/webui/master/static/js/app.js
index e899452..26cd36f 100644
--- a/src/webui/master/static/js/app.js
+++ b/src/webui/master/static/js/app.js
@@ -84,12 +84,17 @@
paginationConfig.rotate = false;
}])
.filter('truncateMesosID', function() {
+ // Returns a truncated ID, for example:
+ // Input: 9d4b2f2b-a759-4458-bebf-7d3507a6f0ca-S9
+ // Output: ...bebf-7d3507a6f0ca-S9
+ //
+ // Note that an ellipsis is used for display purposes.
return function(id) {
if (id) {
var truncatedIdParts = id.split('-');
if (truncatedIdParts.length > 3) {
- return '…' + truncatedIdParts.splice(3, 3).join('-');
+ return '\u2026' + truncatedIdParts.splice(3, 3).join('-');
} else {
return id;
}