You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/30 09:16:50 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #5396: Remove ShardingRule.toRules()
terrymanu opened a new pull request #5396:
URL: https://github.com/apache/shardingsphere/pull/5396
For #3691.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5396: Remove ShardingRule.toRules()
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5396:
URL: https://github.com/apache/shardingsphere/pull/5396#issuecomment-621728431
## Pull Request Test Coverage Report for [Build 11374](https://coveralls.io/builds/30457255)
* **22** of **39** **(56.41%)** changed or added relevant lines in **15** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.01%**) to **57.483%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationMasterSlaveDataSourceFactory.java](https://coveralls.io/builds/30457255/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationMasterSlaveDataSourceFactory.java#L54) | 0 | 1 | 0.0%
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/30457255/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationShardingDataSourceFactory.java#L54) | 0 | 1 | 0.0%
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java](https://coveralls.io/builds/30457255/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemaFactory.java#L56) | 0 | 1 | 0.0%
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/MasterSlaveSchema.java](https://coveralls.io/builds/30457255/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FMasterSlaveSchema.java#L45) | 0 | 3 | 0.0%
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/30457255/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L50) | 0 | 5 | 0.0%
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/RuleBuilder.java](https://coveralls.io/builds/30457255/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FRuleBuilder.java#L44) | 0 | 6 | 0.0%
<!-- | **Total:** | **22** | **39** | **56.41%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/30457255/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L51) | 2 | 0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/30457255) |
| :-- | --: |
| Change from base [Build 11373](https://coveralls.io/builds/30455529): | 0.01% |
| Covered Lines: | 11972 |
| Relevant Lines: | 20827 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org