You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/03 11:07:52 UTC
[GitHub] [flink] Myracle opened a new pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Myracle opened a new pull request #13051:
URL: https://github.com/apache/flink/pull/13051
## What is the purpose of the change
Flink supports redundant task managers in [FLINK-18625](https://issues.apache.org/jira/browse/FLINK-18625). For a session cluster, there are no redundant task managers at first. After submitting a job, redundant task managers will be allocated. After cancelling the job, redundant task managers will not be released. It would be better to not keep such redundant resources when no job is running.
## Brief change log
- * If timedOutTaskManagers' size equals taskManagerRegistrations' size, no job is running and no need to keep redundant taskManagers. Just release timeout task managers in this case.
## Verifying this change
This change added tests and can be verified as follows:
- *Added test to verify that timeout task managers will be released if no job is running regardless of redundantTaskManagerNum.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13051:
URL: https://github.com/apache/flink/pull/13051#discussion_r466234966
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -1256,7 +1256,10 @@ void checkTaskManagerTimeoutsAndRedundancy() {
}
int slotsDiff = redundantTaskManagerNum * numSlotsPerWorker - freeSlots.size();
- if (slotsDiff > 0) {
+ if (freeSlots.size() == slots.size()) {
Review comment:
I think in a first version this should be good enough. Later one could ask the `ResourceManager.jobLeaderIdService` if there is still a job registered. However, this service also times out the job if no leader registers within a given timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-669609819
@xintongsong @KarmaGYZ Can you review my code? Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
}, {
"hash" : "b387eae159be898230e9b5a410a295f9960dabb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b387eae159be898230e9b5a410a295f9960dabb1",
"triggerType" : "PUSH"
}, {
"hash" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5281",
"triggerID" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b387eae159be898230e9b5a410a295f9960dabb1 UNKNOWN
* 8234d87e7f9215067cd88ccd848958b5fd652a61 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
}, {
"hash" : "b387eae159be898230e9b5a410a295f9960dabb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b387eae159be898230e9b5a410a295f9960dabb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d116af64b399759a2c30eda5408e8a0660d1c7d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261)
* b387eae159be898230e9b5a410a295f9960dabb1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
}, {
"hash" : "b387eae159be898230e9b5a410a295f9960dabb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b387eae159be898230e9b5a410a295f9960dabb1",
"triggerType" : "PUSH"
}, {
"hash" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d116af64b399759a2c30eda5408e8a0660d1c7d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261)
* b387eae159be898230e9b5a410a295f9960dabb1 UNKNOWN
* 8234d87e7f9215067cd88ccd848958b5fd652a61 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #13051:
URL: https://github.com/apache/flink/pull/13051#discussion_r466242764
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/TaskManagerCheckInSlotManagerTest.java
##########
@@ -213,6 +212,21 @@ public void testTaskManagerIsNotReleasedInCaseOfConcurrentAllocation() throws Ex
}
}
+ private void checkTaskManagerTimeout(int redundantTaskManagerNum) throws Exception {
+ Executor executor = TestingUtils.defaultExecutor();
+ canBeReleasedFuture.set(CompletableFuture.completedFuture(true));
+ try (SlotManager slotManager = SlotManagerBuilder
+ .newBuilder()
+ .setTaskManagerTimeout(Time.milliseconds(10L))
+ .setRedundantTaskManagerNum(redundantTaskManagerNum)
+ .build()) {
+
+ slotManager.start(resourceManagerId, executor, resourceManagerActions);
Review comment:
Could use `buildAndStartWithDirectExec#buildAndStartWithDirectExec` instead.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -1256,7 +1256,10 @@ void checkTaskManagerTimeoutsAndRedundancy() {
}
int slotsDiff = redundantTaskManagerNum * numSlotsPerWorker - freeSlots.size();
- if (slotsDiff > 0) {
+ if (freeSlots.size() == slots.size()) {
Review comment:
Ok, that makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #13051:
URL: https://github.com/apache/flink/pull/13051#discussion_r468315396
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -1256,7 +1256,10 @@ void checkTaskManagerTimeoutsAndRedundancy() {
}
int slotsDiff = redundantTaskManagerNum * numSlotsPerWorker - freeSlots.size();
- if (slotsDiff > 0) {
+ if (freeSlots.size() == slots.size()) {
Review comment:
If the job failover takes long, then all the idle task managers will timeout and be released. There's few benefit keeping the redundant task managers, since we need to wait for re-launching the other task managers anyway. (Assuming the job needs more task managers than the redundant ones to execute.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
}, {
"hash" : "b387eae159be898230e9b5a410a295f9960dabb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b387eae159be898230e9b5a410a295f9960dabb1",
"triggerType" : "PUSH"
}, {
"hash" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5281",
"triggerID" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "671715738",
"triggerType" : "MANUAL"
}, {
"hash" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5383",
"triggerID" : "671715738",
"triggerType" : "MANUAL"
}, {
"hash" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5383",
"triggerID" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b387eae159be898230e9b5a410a295f9960dabb1 UNKNOWN
* Unknown: [CANCELED](TBD)
* 0742547410ef77d61dd2566555e0540ff1558f4c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #13051:
URL: https://github.com/apache/flink/pull/13051#discussion_r466102349
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -1256,7 +1256,10 @@ void checkTaskManagerTimeoutsAndRedundancy() {
}
int slotsDiff = redundantTaskManagerNum * numSlotsPerWorker - freeSlots.size();
- if (slotsDiff > 0) {
+ if (freeSlots.size() == slots.size()) {
Review comment:
If job's failover takes a long time, we could run into this scenario as well. In that case, the redundant TM mechanism will not take effect as expected. WDYT about this?
cc @tillrohrmann
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-671735098
Thank you, @xintongsong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85e3558062b8a70e7fa565b9fab624c5dd13916a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667962102
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2e4e573a5d6d1d63291fb380f251f999ee3983a0 (Mon Aug 03 11:09:33 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-671715738
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85e3558062b8a70e7fa565b9fab624c5dd13916a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
}, {
"hash" : "b387eae159be898230e9b5a410a295f9960dabb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b387eae159be898230e9b5a410a295f9960dabb1",
"triggerType" : "PUSH"
}, {
"hash" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5281",
"triggerID" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"triggerType" : "PUSH"
}, {
"hash" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "671715738",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "671715738",
"triggerType" : "MANUAL"
}, {
"hash" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b387eae159be898230e9b5a410a295f9960dabb1 UNKNOWN
* Unknown: [CANCELED](TBD)
* 0742547410ef77d61dd2566555e0540ff1558f4c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #13051:
URL: https://github.com/apache/flink/pull/13051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d116af64b399759a2c30eda5408e8a0660d1c7d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
}, {
"hash" : "b387eae159be898230e9b5a410a295f9960dabb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b387eae159be898230e9b5a410a295f9960dabb1",
"triggerType" : "PUSH"
}, {
"hash" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5281",
"triggerID" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"triggerType" : "PUSH"
}, {
"hash" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "671715738",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "671715738",
"triggerType" : "MANUAL"
}, {
"hash" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0742547410ef77d61dd2566555e0540ff1558f4c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b387eae159be898230e9b5a410a295f9960dabb1 UNKNOWN
* 0742547410ef77d61dd2566555e0540ff1558f4c UNKNOWN
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
}, {
"hash" : "b387eae159be898230e9b5a410a295f9960dabb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b387eae159be898230e9b5a410a295f9960dabb1",
"triggerType" : "PUSH"
}, {
"hash" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5281",
"triggerID" : "8234d87e7f9215067cd88ccd848958b5fd652a61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d116af64b399759a2c30eda5408e8a0660d1c7d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5261)
* b387eae159be898230e9b5a410a295f9960dabb1 UNKNOWN
* 8234d87e7f9215067cd88ccd848958b5fd652a61 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-670279387
Thanks, @KarmaGYZ @tillrohrmann. I learn a lot from the discussion . The code is modified referring to the advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85e3558062b8a70e7fa565b9fab624c5dd13916a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13051: [FLINK-18760][runtime] Redundant task managers should be released when there's no job running in session cluster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13051:
URL: https://github.com/apache/flink/pull/13051#issuecomment-667970728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119",
"triggerID" : "85e3558062b8a70e7fa565b9fab624c5dd13916a",
"triggerType" : "PUSH"
}, {
"hash" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d116af64b399759a2c30eda5408e8a0660d1c7d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85e3558062b8a70e7fa565b9fab624c5dd13916a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5119)
* d116af64b399759a2c30eda5408e8a0660d1c7d9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org