You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/09/24 09:43:16 UTC
(datafusion) 01/01: docs: point proto CONTRIBUTING at proto-models/gen (#25666)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-25666-9951f0b351b751d26b66085190ac969ecd53b34d
in repository https://gitbox.apache.org/repos/asf/datafusion.git
commit f6a95abde9cd44248d089c06ef723c2d0368f04f
Author: Zain Qureshi <43...@users.noreply.github.com>
AuthorDate: Thu Sep 24 09:42:50 2026 +0000
docs: point proto CONTRIBUTING at proto-models/gen (#25666)
## Which issue does this PR close?
None; small docs fix.
## Rationale for this change
`datafusion/proto/CONTRIBUTING.md` says `./regen.sh` invokes the Rust
binary in [gen](./gen), and links there twice. That directory is gone:
generation moved to `datafusion-proto-models`, and
`datafusion/proto/regen.sh` is now a wrapper that runs
`datafusion/proto-models/regen.sh`, which runs `cargo run
--manifest-path datafusion/proto-models/gen/Cargo.toml`. So both links
404, and a contributor looking for the generator's dependencies is sent
to a path that doesn't exist.
## What changes are included in this PR?
Both `./gen` links now point to `../proto-models/gen`.
## What is the testing strategy for this PR?
Docs only. Checked the target exists at current `main` and followed the
`regen.sh` chain to confirm it is the binary that actually runs.
## Are there any user-facing changes?
No.
This PR was prepared with AI assistance (Claude Code). I traced the
`regen.sh` chain myself.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5.5 (1M context) <no...@anthropic.com>
---
datafusion/proto/CONTRIBUTING.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/datafusion/proto/CONTRIBUTING.md b/datafusion/proto/CONTRIBUTING.md
index db3658c726..b0e74e89ed 100644
--- a/datafusion/proto/CONTRIBUTING.md
+++ b/datafusion/proto/CONTRIBUTING.md
@@ -19,9 +19,9 @@
## Generated Code
-The prost/tonic code can be generated by running `./regen.sh`, which in turn invokes the Rust binary located in [gen](./gen)
+The prost/tonic code can be generated by running `./regen.sh`, which in turn invokes the Rust binary located in [proto-models/gen](../proto-models/gen)
-This is necessary after modifying the protobuf definitions or altering the dependencies of [gen](./gen), and requires a
+This is necessary after modifying the protobuf definitions or altering the dependencies of [proto-models/gen](../proto-models/gen), and requires a
valid installation of [protoc] (see [installation instructions] for details).
```bash
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org