You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Bryan Call (JIRA)" <ji...@apache.org> on 2011/06/07 19:27:58 UTC
[jira] [Created] (TS-829) socks stats cleanup - some stats are
registered, but not used
socks stats cleanup - some stats are registered, but not used
-------------------------------------------------------------
Key: TS-829
URL: https://issues.apache.org/jira/browse/TS-829
Project: Traffic Server
Issue Type: Bug
Components: Network
Affects Versions: 3.0.0
Reporter: Bryan Call
Priority: Minor
>From reviewing TS-818 I noticed that the stats that were being double resisted are not used. Some cleanup work should be done for the socks stats.
Stats that are registered, but not used in the code:
[bcall@snowball traffic.git]$ grep -r proxy.process.socks iocore/net/Net.cc
"proxy.process.socks.connections_successful",
"proxy.process.socks.connections_unsuccessful",
"proxy.process.socks.connections_currently_open",
These stats are used some tests, so maybe they should be added back into the code.
[bcall@snowball traffic.git]$ grep -rl --binary-files=without-match proxy.process.socks.connections_ *
iocore/net/Net.cc
mgmt/api/remote/APITestCliRemote.cc
test/plugin/test-mgmt/test-mgmt.c
I did however see these stats being used:
[bcall@snowball traffic.git]$ grep -r SOCKSPROXY_ *
proxy/SocksProxy.cc:#define SOCKSPROXY_INC_STAT(x) \
proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-829) socks stats cleanup - some stats are
registered, but not used
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-829:
-----------------------------
Fix Version/s: (was: 3.1.1)
3.1.2
> socks stats cleanup - some stats are registered, but not used
> -------------------------------------------------------------
>
> Key: TS-829
> URL: https://issues.apache.org/jira/browse/TS-829
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Affects Versions: 3.0.0
> Reporter: Bryan Call
> Priority: Minor
> Fix For: 3.1.2
>
>
> From reviewing TS-818 I noticed that the stats that were being double resisted are not used. Some cleanup work should be done for the socks stats.
> Stats that are registered, but not used in the code:
> [bcall@snowball traffic.git]$ grep -r proxy.process.socks iocore/net/Net.cc
> "proxy.process.socks.connections_successful",
> "proxy.process.socks.connections_unsuccessful",
> "proxy.process.socks.connections_currently_open",
> These stats are used some tests, so maybe they should be added back into the code.
> [bcall@snowball traffic.git]$ grep -rl --binary-files=without-match proxy.process.socks.connections_ *
> iocore/net/Net.cc
> mgmt/api/remote/APITestCliRemote.cc
> test/plugin/test-mgmt/test-mgmt.c
> I did however see these stats being used:
> [bcall@snowball traffic.git]$ grep -r SOCKSPROXY_ *
> proxy/SocksProxy.cc:#define SOCKSPROXY_INC_STAT(x) \
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-829) socks stats cleanup - some stats are
registered, but not used
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-829:
-----------------------------
Fix Version/s: (was: 3.1.2)
3.1.3
I'm moving all 3.1.2 bugs out to 3.1.3, and we can move some 3.1.1 bugs out to 3.1.2, to get some release action going.
> socks stats cleanup - some stats are registered, but not used
> -------------------------------------------------------------
>
> Key: TS-829
> URL: https://issues.apache.org/jira/browse/TS-829
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Affects Versions: 3.0.0
> Reporter: Bryan Call
> Priority: Minor
> Fix For: 3.1.3
>
>
> From reviewing TS-818 I noticed that the stats that were being double resisted are not used. Some cleanup work should be done for the socks stats.
> Stats that are registered, but not used in the code:
> [bcall@snowball traffic.git]$ grep -r proxy.process.socks iocore/net/Net.cc
> "proxy.process.socks.connections_successful",
> "proxy.process.socks.connections_unsuccessful",
> "proxy.process.socks.connections_currently_open",
> These stats are used some tests, so maybe they should be added back into the code.
> [bcall@snowball traffic.git]$ grep -rl --binary-files=without-match proxy.process.socks.connections_ *
> iocore/net/Net.cc
> mgmt/api/remote/APITestCliRemote.cc
> test/plugin/test-mgmt/test-mgmt.c
> I did however see these stats being used:
> [bcall@snowball traffic.git]$ grep -r SOCKSPROXY_ *
> proxy/SocksProxy.cc:#define SOCKSPROXY_INC_STAT(x) \
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-829) socks stats cleanup - some stats are
registered, but not used
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-829:
-----------------------------
Fix Version/s: 3.1.0
> socks stats cleanup - some stats are registered, but not used
> -------------------------------------------------------------
>
> Key: TS-829
> URL: https://issues.apache.org/jira/browse/TS-829
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Affects Versions: 3.0.0
> Reporter: Bryan Call
> Priority: Minor
> Fix For: 3.1.0
>
>
> From reviewing TS-818 I noticed that the stats that were being double resisted are not used. Some cleanup work should be done for the socks stats.
> Stats that are registered, but not used in the code:
> [bcall@snowball traffic.git]$ grep -r proxy.process.socks iocore/net/Net.cc
> "proxy.process.socks.connections_successful",
> "proxy.process.socks.connections_unsuccessful",
> "proxy.process.socks.connections_currently_open",
> These stats are used some tests, so maybe they should be added back into the code.
> [bcall@snowball traffic.git]$ grep -rl --binary-files=without-match proxy.process.socks.connections_ *
> iocore/net/Net.cc
> mgmt/api/remote/APITestCliRemote.cc
> test/plugin/test-mgmt/test-mgmt.c
> I did however see these stats being used:
> [bcall@snowball traffic.git]$ grep -r SOCKSPROXY_ *
> proxy/SocksProxy.cc:#define SOCKSPROXY_INC_STAT(x) \
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-829) socks stats cleanup - some stats are
registered, but not used
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-829:
-----------------------------
Fix Version/s: (was: 3.1.6)
3.3.0
Moving out to v3.3.0, move back to 3.1.4 if this will be work on *soon*.
> socks stats cleanup - some stats are registered, but not used
> -------------------------------------------------------------
>
> Key: TS-829
> URL: https://issues.apache.org/jira/browse/TS-829
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Affects Versions: 3.0.0
> Reporter: Bryan Call
> Priority: Minor
> Fix For: 3.3.0
>
>
> From reviewing TS-818 I noticed that the stats that were being double resisted are not used. Some cleanup work should be done for the socks stats.
> Stats that are registered, but not used in the code:
> [bcall@snowball traffic.git]$ grep -r proxy.process.socks iocore/net/Net.cc
> "proxy.process.socks.connections_successful",
> "proxy.process.socks.connections_unsuccessful",
> "proxy.process.socks.connections_currently_open",
> These stats are used some tests, so maybe they should be added back into the code.
> [bcall@snowball traffic.git]$ grep -rl --binary-files=without-match proxy.process.socks.connections_ *
> iocore/net/Net.cc
> mgmt/api/remote/APITestCliRemote.cc
> test/plugin/test-mgmt/test-mgmt.c
> I did however see these stats being used:
> [bcall@snowball traffic.git]$ grep -r SOCKSPROXY_ *
> proxy/SocksProxy.cc:#define SOCKSPROXY_INC_STAT(x) \
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
> proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira