You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Teemu Torma (JIRA)" <ji...@apache.org> on 2007/03/13 18:12:34 UTC

[jira] Created: (AMQCPP-87) ActiveMQConnectionFactory creates only one unique clientId

ActiveMQConnectionFactory creates only one unique clientId
----------------------------------------------------------

                 Key: AMQCPP-87
                 URL: https://issues.apache.org/activemq/browse/AMQCPP-87
             Project: ActiveMQ C++ Client
          Issue Type: Bug
          Components: Openwire
    Affects Versions: 2.0
            Reporter: Teemu Torma
         Assigned To: Nathan Mittler
         Attachments: connection-factory.patch

ActiveMQConnectionFactory creates only one unique clientId.  This prevents creating multiple connections using the same factory.

The attached patch creates uuid once, and adds a counter to it if needed.  It is just a proposal, and I have only very quickly tested it on linux/gcc 4.1.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQCPP-87) ActiveMQConnectionFactory creates only one unique clientId

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQCPP-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish updated AMQCPP-87:
-------------------------------

         Priority: Minor  (was: Major)
    Fix Version/s: 2.0

> ActiveMQConnectionFactory creates only one unique clientId
> ----------------------------------------------------------
>
>                 Key: AMQCPP-87
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-87
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Openwire
>    Affects Versions: 2.0
>            Reporter: Teemu Torma
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: connection-factory.patch
>
>
> ActiveMQConnectionFactory creates only one unique clientId.  This prevents creating multiple connections using the same factory.
> The attached patch creates uuid once, and adds a counter to it if needed.  It is just a proposal, and I have only very quickly tested it on linux/gcc 4.1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (AMQCPP-87) ActiveMQConnectionFactory creates only one unique clientId

Posted by "Teemu Torma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQCPP-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Teemu Torma closed AMQCPP-87.
-----------------------------


> ActiveMQConnectionFactory creates only one unique clientId
> ----------------------------------------------------------
>
>                 Key: AMQCPP-87
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-87
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Openwire
>    Affects Versions: 2.0
>            Reporter: Teemu Torma
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: connection-factory.patch
>
>
> ActiveMQConnectionFactory creates only one unique clientId.  This prevents creating multiple connections using the same factory.
> The attached patch creates uuid once, and adds a counter to it if needed.  It is just a proposal, and I have only very quickly tested it on linux/gcc 4.1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQCPP-87) ActiveMQConnectionFactory creates only one unique clientId

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQCPP-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQCPP-87.
--------------------------------

    Resolution: Fixed

Fixed in Trunk

cms::ConnectionFactory has changed slightly, and ActiveMQConnectionFactory has been refactored.  There are now a couple methods that can be used to create a new connection, one of which is static and allows for all parameters of the connection to be set there.  



> ActiveMQConnectionFactory creates only one unique clientId
> ----------------------------------------------------------
>
>                 Key: AMQCPP-87
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-87
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Openwire
>    Affects Versions: 2.0
>            Reporter: Teemu Torma
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: connection-factory.patch
>
>
> ActiveMQConnectionFactory creates only one unique clientId.  This prevents creating multiple connections using the same factory.
> The attached patch creates uuid once, and adds a counter to it if needed.  It is just a proposal, and I have only very quickly tested it on linux/gcc 4.1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQCPP-87) ActiveMQConnectionFactory creates only one unique clientId

Posted by "Teemu Torma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_38812 ] 

Teemu Torma commented on AMQCPP-87:
-----------------------------------


UUID generation might be slow, that is why counter.  I don't really care 
which way though.

I disagree the new UUID would be more unique than counter approach.  The 
UUID is already unique for the factory, and adding something to it does 
not make it less unique.


> ActiveMQConnectionFactory creates only one unique clientId
> ----------------------------------------------------------
>
>                 Key: AMQCPP-87
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-87
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Openwire
>    Affects Versions: 2.0
>            Reporter: Teemu Torma
>         Assigned To: Nathan Mittler
>         Attachments: connection-factory.patch
>
>
> ActiveMQConnectionFactory creates only one unique clientId.  This prevents creating multiple connections using the same factory.
> The attached patch creates uuid once, and adds a counter to it if needed.  It is just a proposal, and I have only very quickly tested it on linux/gcc 4.1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AMQCPP-87) ActiveMQConnectionFactory creates only one unique clientId

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQCPP-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish reassigned AMQCPP-87:
----------------------------------

    Assignee: Timothy Bish  (was: Nathan Mittler)

> ActiveMQConnectionFactory creates only one unique clientId
> ----------------------------------------------------------
>
>                 Key: AMQCPP-87
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-87
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Openwire
>    Affects Versions: 2.0
>            Reporter: Teemu Torma
>         Assigned To: Timothy Bish
>             Fix For: 2.0
>
>         Attachments: connection-factory.patch
>
>
> ActiveMQConnectionFactory creates only one unique clientId.  This prevents creating multiple connections using the same factory.
> The attached patch creates uuid once, and adds a counter to it if needed.  It is just a proposal, and I have only very quickly tested it on linux/gcc 4.1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQCPP-87) ActiveMQConnectionFactory creates only one unique clientId

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_38811 ] 

Timothy Bish commented on AMQCPP-87:
------------------------------------

Adding a count to a UUID is not the right thing to do, as you could just create a new UUID which would have more of a guarantee of uniqueness than arbitrarily adding one to an old UUID.

> ActiveMQConnectionFactory creates only one unique clientId
> ----------------------------------------------------------
>
>                 Key: AMQCPP-87
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-87
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Openwire
>    Affects Versions: 2.0
>            Reporter: Teemu Torma
>         Assigned To: Nathan Mittler
>         Attachments: connection-factory.patch
>
>
> ActiveMQConnectionFactory creates only one unique clientId.  This prevents creating multiple connections using the same factory.
> The attached patch creates uuid once, and adds a counter to it if needed.  It is just a proposal, and I have only very quickly tested it on linux/gcc 4.1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.