You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/01 15:05:58 UTC

[GitHub] [zookeeper] symat opened a new pull request #1833: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

symat opened a new pull request #1833:
URL: https://github.com/apache/zookeeper/pull/1833


   This is the ZOOKEEPER-4477 patch for branch-3.5. Similar to the same fix on newer branches
   but using junit 4 in the tests (the junit upgrade happened in ZooKeeper 3.6).
   
   This bug is similar to the one fixed in https://issues.apache.org/jira/browse/KAFKA-12730.
   
   Our Kerberos ticket refresh thread performs re-login by logging out and then logging in again. If
   login fails, we retry after some sleep. Every reLogin() operation performs loginContext.logout()
   and loginContext.login(). If login fails, we end up with two consecutive logouts. This used to
   work in older Java versions, but from Java 9 onwards, this results in a NullPointerException due
   to https://bugs.openjdk.java.net/browse/JDK-8173069. We should check if logout is required before
   attempting logout.
   
   I fixed the issue and added a new unit test to test some ticket renewal scenarios. I managed to
   reproduce the problem in KerberosTicketRenewalTest.shouldRecoverIfKerberosNotAvailableForSomeTime()
   which (before the fix) failed with Java13 but succeeded with Java8.
   
   (cherry picked from commit 73ea6aaffc7a29a31df9007244f96d8d67fef953)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli closed pull request #1833: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1833:
URL: https://github.com/apache/zookeeper/pull/1833


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1833: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1833:
URL: https://github.com/apache/zookeeper/pull/1833#issuecomment-1055575588


   merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1833: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1833:
URL: https://github.com/apache/zookeeper/pull/1833#issuecomment-1055582132


   thank you!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1833: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1833:
URL: https://github.com/apache/zookeeper/pull/1833#issuecomment-1055556674


   This is similar to https://github.com/apache/zookeeper/pull/1828 and https://github.com/apache/zookeeper/pull/1830 just on top of branch-3.6. I mainly submitted this as a separate PR to trigger a CI run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1833: ZOOKEEPER-4477: Single Kerberos ticket renewal failure can prevent all future renewals since Java 9

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1833:
URL: https://github.com/apache/zookeeper/pull/1833#issuecomment-1055576908


   committed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org