You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/08/05 04:41:10 UTC

Re: Review Request 52103: Implemented quota update in `/quota` endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52103/
-----------------------------------------------------------

(Updated Aug. 5, 2017, 4:41 a.m.)


Review request for mesos, Alexander Rukletsov, Xiaojian Huang, and Neil Conway.


Changes
-------

Implement update through same `POST` method and `setQuota` functions.


Summary (updated)
-----------------

Implemented quota update in `/quota` endpoint.


Bugs: MESOS-4941
    https://issues.apache.org/jira/browse/MESOS-4941


Repository: mesos


Description (updated)
-------

This patch implemented atomic quota update through
on the `/quota` endpoint by relaxing existing `setQuota`
functions in allocator interface.

Changes included:
- implementation in hierarchical allocator;
- implementation in quota_handler;
- some integration tests for updating a quota.

More tests around resource rescind and operator API
implementation will be sent in later patches.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035 
  src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 
  src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 
  src/master/quota_handler.cpp 26b2dc86fa44dfdf6e0a6c4993c754a6384dd851 
  src/tests/master_quota_tests.cpp 9d52f767c112abd55ab3f49d172eb6e3caea511b 


Diff: https://reviews.apache.org/r/52103/diff/6/

Changes: https://reviews.apache.org/r/52103/diff/5-6/


Testing
-------


Thanks,

Zhitao Li