You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/17 09:40:13 UTC

[GitHub] [echarts] Bilge opened a new issue #14696: markLine requires symbolOffset (BC break)

Bilge opened a new issue #14696:
URL: https://github.com/apache/echarts/issues/14696


   ### Version
   5.1.0
   
   ### Steps to reproduce
   ```js
               series: [{
                   step: 'end',
                   data: AppCharts.dataset,
                   markLine: {
                       data: [
                           {
                               yAxis: 123,
                               lineStyle: {
                                   color: '#fff3',
                               },
                               label: {
                                   formatter: 'min\n${c}',
                                   fontSize: 12,
                                   color: '#677a59',
                               },
                           },
                       ],
                   },
               }],
   ```
   
   ### What is expected?
   `symbolOffset` should be optional.
   
   ### What is actually happening?
   `symbolOffset` is required.
   
   > TS2322: Type '{ yAxis: number; lineStyle: { color: string; }; label: { formatter: string; fontSize: number; color: string; }; }' is not assignable to type 'MarkLine1DDataItemOption | MarkLine2DDataItemOption'.
     Property 'symbolOffset' is missing in type '{ yAxis: number; lineStyle: { color: string; }; label: { formatter: string; fontSize: number; color: string; }; }' but required in type 'MarkLine1DDataItemOption'.
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on issue #14696: markLine requires symbolOffset (BC break)

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #14696:
URL: https://github.com/apache/echarts/issues/14696#issuecomment-822104689


   Thanks for the feedback. It has been fixed by #14693.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart closed issue #14696: markLine requires symbolOffset (BC break)

Posted by GitBox <gi...@apache.org>.
plainheart closed issue #14696:
URL: https://github.com/apache/echarts/issues/14696


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #14696: markLine requires symbolOffset (BC break)

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #14696:
URL: https://github.com/apache/echarts/issues/14696#issuecomment-821797049


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org