You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/08 01:09:59 UTC

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1855: fix: default cors plugin formdata validation error

liuxiran commented on a change in pull request #1855:
URL: https://github.com/apache/apisix-dashboard/pull/1855#discussion_r628650747



##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -121,6 +122,12 @@ const PluginDetail: React.FC<Props> = ({
     if (name === 'cors') {
       const formData = UIForm.getFieldsValue();
       const newMethods = formData.allow_methods.join(",");
+      const compactAllowRegex = compact(formData.allow_origins_by_regex);

Review comment:
       > Hi, we may add the test case for this case.
   
   ok, on the way




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org