You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/09/20 14:29:56 UTC

[GitHub] [ozone] adoroszlai opened a new pull request #2663: HDDS-5765. Test cluster provider possibly returns null

adoroszlai opened a new pull request #2663:
URL: https://github.com/apache/ozone/pull/2663


   ## What changes were proposed in this pull request?
   
   `MiniOzoneClusterProvider` may timeout (100 seconds) while waiting for a cluster to become available.  In this case it simply returns `null` without warning.  This results in NPE when trying to use the cluster in test.
   
   ```
   testAllDataNodeFailuresAfterScmPostFinalizeUpgrade  Time elapsed: 100.076 s  <<< ERROR!
   java.lang.NullPointerException
   	at org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade.init(TestHDDSUpgrade.java:173)
   	at org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade.setUp(TestHDDSUpgrade.java:135)
   ```
   
   This change makes `MiniOzoneClusterProvider` throw exception if cluster could not be started.  This way test failure is a bit more explicit.
   
   https://issues.apache.org/jira/browse/HDDS-5765
   
   ## How was this patch tested?
   
   Regular CI.
   https://github.com/adoroszlai/hadoop-ozone/runs/3651226035


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #2663: HDDS-5765. Test cluster provider possibly returns null

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2663:
URL: https://github.com/apache/ozone/pull/2663


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #2663: HDDS-5765. Test cluster provider possibly returns null

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2663:
URL: https://github.com/apache/ozone/pull/2663#issuecomment-923826275


   Thanks @sodonnel for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org