You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/22 20:29:57 UTC
[GitHub] [spark] tdg5 opened a new pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
tdg5 opened a new pull request #34989:
URL: https://github.com/apache/spark/pull/34989
# branch-3.2 version!
For master version see : https://github.com/apache/spark/pull/34745
Augments the JdbcConnectionProvider API such that a provider can indicate that it will need to modify the global security configuration when establishing a connection, and as such, if access to the global security configuration should be synchronized to prevent races.
### What changes were proposed in this pull request?
As suggested by @gaborgsomogyi [here](https://github.com/apache/spark/pull/29024/files#r755788709), augments the `JdbcConnectionProvider` API to include a `modifiesSecurityContext` method that can be used by `ConnectionProvider` to determine when `SecurityConfigurationLock.synchronized` is required to avoid race conditions when establishing a JDBC connection.
### Why are the changes needed?
Provides a path forward for working around a significant bottleneck introduced by synchronizing `SecurityConfigurationLock` every time a connection is established. The synchronization isn't always needed and it should be at the discretion of the `JdbcConnectionProvider` to determine when locking is necessary. See [SPARK-37391](https://issues.apache.org/jira/browse/SPARK-37391) or [this thread](https://github.com/apache/spark/pull/29024/files#r754441783).
### Does this PR introduce _any_ user-facing change?
Any existing implementations of `JdbcConnectionProvider` will need to add a definition of `modifiesSecurityContext`. I'm also open to adding a default implementation, but it seemed to me that requiring an explicit implementation of the method was preferable.
A drop-in implementation that would continue the existing behavior is:
```scala
override def modifiesSecurityContext(
driver: Driver,
options: Map[String, String]
): Boolean = true
```
### How was this patch tested?
Unit tests. Also ran a real workflow by swapping in a locally published version of `spark-sql` into my local spark 3.2.0 installation's jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-1000003999
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-999991197
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-999966412
**[Test build #146495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146495/testReport)** for PR 34989 at commit [`359dbe6`](https://github.com/apache/spark/commit/359dbe6071b67ef53d58ca300e15bb9d1ed35bee).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-1000022960
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-999872460
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-999979805
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-1000014753
**[Test build #146495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146495/testReport)** for PR 34989 at commit [`359dbe6`](https://github.com/apache/spark/commit/359dbe6071b67ef53d58ca300e15bb9d1ed35bee).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-999956960
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-1000603604
Merged to branch-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-1000003999
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-1000022960
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-999966412
**[Test build #146495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146495/testReport)** for PR 34989 at commit [`359dbe6`](https://github.com/apache/spark/commit/359dbe6071b67ef53d58ca300e15bb9d1ed35bee).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34989:
URL: https://github.com/apache/spark/pull/34989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-1000044198
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34989: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34989:
URL: https://github.com/apache/spark/pull/34989#issuecomment-999872460
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org