You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 22:00:46 UTC

[GitHub] [beam] kennknowles opened a new issue, #19028: Beam SQL operator side condition validation is sensitive to optimization

kennknowles opened a new issue, #19028:
URL: https://github.com/apache/beam/issues/19028

   Beam SQL converts Calcite's operators to Beam SQL operators post-optimization, when the final rels are being converted to a pipeline. This means that the optimization process can obscure the ability to validate things easily.
   
   Specifically, for a `CEIL(date TO DAY)` we only support rounding to month or year (because of the underlying Calcite implementation. We want to be able to get the `DAY` and validate it before running. Today this is not validated properly because it is inconvenient.
   
   Before optimization, we can check that the second operand is a symbol and see what it is. After optimization, the conversion to Calc hides it behind a LocalRef. We could look up the LocalRef but it would be cleaner to avoid evaluation-like logic during type checking/validation phase.
   
   Imported from Jira [BEAM-4621](https://issues.apache.org/jira/browse/BEAM-4621). Original Jira may contain additional context.
   Reported by: kenn.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org