You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/04 14:19:11 UTC
[GitHub] [beam] damccorm opened a new pull request, #17263: [BEAM-12815] Fix flink postcommits
damccorm opened a new pull request, #17263:
URL: https://github.com/apache/beam/pull/17263
This adds our failing flink post commit test to the exclusion list and undoes an attempted fix from #17227 - at the moment I'm going to write up my findings thus far and stop looking into it since it is lower priority than some other work.
The fix from #17227 didn't work because it attempts to add args to the flink shadowJar build step, but that remains cached even when you add args apparently (which sorta makes sense to me, that way we don't have to rebuild it every time). The underlying issue is the same as the precommit issue fixed by https://github.com/apache/beam/pull/17067 but we spin up flink differently in our post commits and so our config change doesn't affect flink in those instances.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #17263: [BEAM-12815] Fix flink postcommits
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #17263:
URL: https://github.com/apache/beam/pull/17263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17263: [BEAM-12815] Fix flink postcommits
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17263:
URL: https://github.com/apache/beam/pull/17263#issuecomment-1087619125
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17263: [BEAM-12815] Fix flink postcommits
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17263:
URL: https://github.com/apache/beam/pull/17263#issuecomment-1087712852
R: @lostluck for final approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17263: [BEAM-12815] Fix flink postcommits
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17263:
URL: https://github.com/apache/beam/pull/17263#issuecomment-1087678356
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17263: [BEAM-12815] Fix flink postcommits
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17263:
URL: https://github.com/apache/beam/pull/17263#issuecomment-1087619130
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17263: [BEAM-12815] Fix flink postcommits
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17263:
URL: https://github.com/apache/beam/pull/17263#issuecomment-1087619124
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17263: [BEAM-12815] Fix flink postcommits
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17263:
URL: https://github.com/apache/beam/pull/17263#issuecomment-1087619131
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org